Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2757073002: Cleanup of how -enableDesktopUserAgent uses NavigationManager utility. (Closed)

Created:
3 years, 9 months ago by pkl (ping after 24h if needed)
Modified:
3 years, 9 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup of how -enableDesktopUserAgent uses NavigationManager utility. Review-Url: https://codereview.chromium.org/2757073002 Cr-Commit-Position: refs/heads/master@{#457961} Committed: https://chromium.googlesource.com/chromium/src/+/7f38e48ab4ee07afa49a7d415296b7db3fc14e06

Patch Set 1 #

Patch Set 2 : Added DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -15 lines) Patch
M ios/chrome/browser/tabs/tab.mm View 1 2 chunks +10 lines, -12 lines 0 comments Download
M ios/chrome/browser/web/navigation_manager_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/web/navigation_manager_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/web/navigation_manager_util_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
pkl (ping after 24h if needed)
FYI - I will deal with the all-redirects case next.
3 years, 9 months ago (2017-03-18 00:37:30 UTC) #2
Eugene But (OOO till 7-30)
Thanks for cleanup! lgtm
3 years, 9 months ago (2017-03-18 00:44:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757073002/20001
3 years, 9 months ago (2017-03-18 05:46:53 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-18 05:58:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7f38e48ab4ee07afa49a7d415296...

Powered by Google App Engine
This is Rietveld 408576698