Cleanup of how -enableDesktopUserAgent uses NavigationManager utility.

ios/chrome/browser/tabs/tab.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/tabs/tab.h"
 
 #import <CoreLocation/CoreLocation.h>
 #import <UIKit/UIKit.h>
 
 #include <utility>
@@ skipping 1471 matching lines @@
          visibleItem->GetUserAgentType() == web::UserAgentType::DESKTOP;
 }
 
 - (void)enableDesktopUserAgent {
   DCHECK_EQ(self.usesDesktopUserAgent, NO);
   DCHECK([self navigationManager]);
   [self navigationManager]->OverrideDesktopUserAgentForNextPendingItem();
 }
 
 - (void)reloadForDesktopUserAgent {
-  // |loadWithParams| will recreate the removed UIWebView.
+  // This removes the web view, which will be recreated at the end of this.
   [self.webController requirePageReconstruction];
 
   // TODO(crbug.com/228171): A hack in session_controller -addPendingItem
   // discusses making tab responsible for distinguishing history stack
-  // navigation from new navigations. Because we want a new navigation here, we
-  // use |PAGE_TRANSITION_FORM_SUBMIT|. When session_controller changes, so
-  // should this.
-  ui::PageTransition transition =
-      ui::PageTransitionFromInt(ui::PAGE_TRANSITION_FORM_SUBMIT);
-  DCHECK([self navigationManager]);
+  // navigation from new navigations.
+  web::NavigationManager* navigationManager = [self navigationManager];
+  DCHECK(navigationManager);
   web::NavigationItem* lastNonRedirectedItem =
-      GetLastNonRedirectedItem([self navigationManager]);
+      GetLastNonRedirectedItem(navigationManager);
   if (!lastNonRedirectedItem)
     return;
 
-  // |originalUrl| will be empty if a page was open by DOM.
+  // |reloadURL| will be empty if a page was open by DOM.
   GURL reloadURL(lastNonRedirectedItem->GetOriginalRequestURL());
   if (reloadURL.is_empty()) {
     DCHECK(
         [[self navigationManagerImpl]->GetSessionController() isOpenedByDOM]);
     reloadURL = lastNonRedirectedItem->GetVirtualURL();
   }
 
   web::NavigationManager::WebLoadParams params(reloadURL);
   params.referrer = lastNonRedirectedItem->GetReferrer();
-  params.transition_type = transition;
-  if (self.navigationManager)
-    self.navigationManager->LoadURLWithParams(params);
+  // A new navigation is needed here for reloading with desktop User-Agent.
+  params.transition_type =
+      ui::PageTransitionFromInt(ui::PAGE_TRANSITION_FORM_SUBMIT);
+  navigationManager->LoadURLWithParams(params);
 }
 
 - (id<SnapshotOverlayProvider>)snapshotOverlayProvider {
   return snapshotOverlayProvider_.get();
 }
 
 - (void)setSnapshotOverlayProvider:
     (id<SnapshotOverlayProvider>)snapshotOverlayProvider {
   snapshotOverlayProvider_.reset(snapshotOverlayProvider);
 }
@@ skipping 569 matching lines @@
 
 - (TabModel*)parentTabModel {
   return parentTabModel_;
 }
 
 - (FormInputAccessoryViewController*)inputAccessoryViewController {
   return inputAccessoryViewController_.get();
 }
 
 @end