Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Side by Side Diff: ios/chrome/browser/web/navigation_manager_util_unittest.mm

Issue 2757073002: Cleanup of how -enableDesktopUserAgent uses NavigationManager utility. (Closed)
Patch Set: Added DCHECK Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/chrome/browser/web/navigation_manager_util.mm ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/chrome/browser/web/navigation_manager_util.h" 5 #import "ios/chrome/browser/web/navigation_manager_util.h"
6 6
7 #import "ios/web/public/navigation_item.h" 7 #import "ios/web/public/navigation_item.h"
8 #import "ios/web/public/test/fakes/test_navigation_manager.h" 8 #import "ios/web/public/test/fakes/test_navigation_manager.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 #import "testing/gtest_mac.h" 10 #import "testing/gtest_mac.h"
11 #include "testing/platform_test.h" 11 #include "testing/platform_test.h"
12 #include "ui/base/page_transition_types.h" 12 #include "ui/base/page_transition_types.h"
13 #include "url/gurl.h" 13 #include "url/gurl.h"
14 14
15 class NavigationManagerUtilTest : public PlatformTest { 15 class NavigationManagerUtilTest : public PlatformTest {
16 protected: 16 protected:
17 web::TestNavigationManager nav_manager_; 17 web::TestNavigationManager nav_manager_;
18 }; 18 };
19 19
20 // Tests that empty navigation manager returns nullptr. 20 // Tests that empty navigation manager returns nullptr.
21 TEST_F(NavigationManagerUtilTest, TestLastNonRedirectedItemEmpty) { 21 TEST_F(NavigationManagerUtilTest, TestLastNonRedirectedItemEmpty) {
22 EXPECT_FALSE(GetLastNonRedirectedItem(nullptr));
22 EXPECT_FALSE(GetLastNonRedirectedItem(&nav_manager_)); 23 EXPECT_FALSE(GetLastNonRedirectedItem(&nav_manager_));
23 } 24 }
24 25
25 // Tests that typed in URL works correctly. 26 // Tests that typed in URL works correctly.
26 TEST_F(NavigationManagerUtilTest, TestLastNonRedirectedItemTypedUrl) { 27 TEST_F(NavigationManagerUtilTest, TestLastNonRedirectedItemTypedUrl) {
27 nav_manager_.AddItem(GURL("http://foo.com/page0"), ui::PAGE_TRANSITION_TYPED); 28 nav_manager_.AddItem(GURL("http://foo.com/page0"), ui::PAGE_TRANSITION_TYPED);
28 web::NavigationItem* item = GetLastNonRedirectedItem(&nav_manager_); 29 web::NavigationItem* item = GetLastNonRedirectedItem(&nav_manager_);
29 ASSERT_TRUE(item); 30 ASSERT_TRUE(item);
30 EXPECT_TRUE(ui::PageTransitionTypeIncludingQualifiersIs( 31 EXPECT_TRUE(ui::PageTransitionTypeIncludingQualifiersIs(
31 item->GetTransitionType(), ui::PAGE_TRANSITION_TYPED)); 32 item->GetTransitionType(), ui::PAGE_TRANSITION_TYPED));
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 nav_manager_.AddItem(GURL("http://foo.com/page0"), ui::PAGE_TRANSITION_TYPED); 75 nav_manager_.AddItem(GURL("http://foo.com/page0"), ui::PAGE_TRANSITION_TYPED);
75 nav_manager_.AddItem(GURL("http://bar.com/redir1"), 76 nav_manager_.AddItem(GURL("http://bar.com/redir1"),
76 ui::PAGE_TRANSITION_CLIENT_REDIRECT); 77 ui::PAGE_TRANSITION_CLIENT_REDIRECT);
77 nav_manager_.AddItem(GURL("http://bar.com/redir2"), 78 nav_manager_.AddItem(GURL("http://bar.com/redir2"),
78 ui::PAGE_TRANSITION_CLIENT_REDIRECT); 79 ui::PAGE_TRANSITION_CLIENT_REDIRECT);
79 web::NavigationItem* item = GetLastNonRedirectedItem(&nav_manager_); 80 web::NavigationItem* item = GetLastNonRedirectedItem(&nav_manager_);
80 ASSERT_TRUE(item); 81 ASSERT_TRUE(item);
81 EXPECT_TRUE(ui::PageTransitionTypeIncludingQualifiersIs( 82 EXPECT_TRUE(ui::PageTransitionTypeIncludingQualifiersIs(
82 item->GetTransitionType(), ui::PAGE_TRANSITION_TYPED)); 83 item->GetTransitionType(), ui::PAGE_TRANSITION_TYPED));
83 } 84 }
OLDNEW
« no previous file with comments | « ios/chrome/browser/web/navigation_manager_util.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698