Reland of Use Layer::INVALID_ID instead of 0 for invalid layers in WebScrollbarLayerImpl

Reland of Use Layer::INVALID_ID instead of 0 for invalid layers in WebScrollbarLayerImpl (patchset #1 id:1 of https://codereview.chromium.org/2757973002/ )

Reason for revert:
Reverting this revert as the root cause was crbug.com/702868

Original issue's description:
> Revert of Use Layer::INVALID_ID instead of 0 for invalid layers in WebScrollbarLayerImpl (patchset #1 id:1 of https://codereview.chromium.org/2751973007/ )
> 
> Reason for revert:
> Possibly affecting CC_Unittests on Android.
> 
> TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer
> https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FAndroid_Tests%2F39440%2F%2B%2Frecipes%2Fsteps%2Fcc_unittests_on_Android%2F0%2Flogs%2FTextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer%2F0
> 
> [ RUN      ] TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer
> ../../cc/layers/texture_layer_unittest.cc:1195: Failure
> Value of: 5
> Expected: commit_count_
> Which is: 4
> [  FAILED  ] TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer (25 ms)
> [----------] 1 test from TextureLayerChangeInvisibleMailboxTest (25 ms total)
> 
> 
> 
> Original issue's description:
> > Use Layer::INVALID_ID instead of 0 for invalid layers in WebScrollbarLayerImpl
> > 
> > This patch fixes a bug where 0, a valid layer id, was used in place of an
> > invalid layer id in the constructor of WebScrollbarLayerImpl. This has
> > been split out of https://codereview.chromium.org/2728253002 which was
> > reverted.
> > 
> > BUG=693740
> > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> > 
> > Review-Url: https://codereview.chromium.org/2751973007
> > Cr-Commit-Position: refs/heads/master@{#457831}
> > Committed: https://chromium.googlesource.com/chromium/src/+/8ffd86e6c9e28bcab01a3f59fb288a7f20df2090
> 
> TBR=ajuma@chromium.org,pdr@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=693740
> 
> Review-Url: https://codereview.chromium.org/2757973002
> Cr-Commit-Position: refs/heads/master@{#457863}
> Committed: https://chromium.googlesource.com/chromium/src/+/9655bcad1aa09a1dc837192866ca8110c0d68563

TBR=ajuma@chromium.org,nektar@chromium.org
BUG=693740
Review-Url: https://codereview.chromium.org/2756343002
Cr-Commit-Position: refs/heads/master@{#457958}
Committed: https://chromium.googlesource.com/chromium/src/+/4bed6671a93fb6d88d49cb8cd4136eb0257f1751

[pdr., 2017-03-18 04:15:49]

Created Reland of Use Layer::INVALID_ID instead of 0 for invalid layers in
WebScrollbarLayerImpl

[pdr., 2017-03-18 04:16:28]

Description was changed from

==========
Reland of Use Layer::INVALID_ID instead of 0 for invalid layers in
WebScrollbarLayerImpl (patchset #1 id:1 of
https://codereview.chromium.org/2757973002/ )

Reason for revert:
Reverting this revert as the root cause was crbug.com/702868

Original issue's description:
> Revert of Use Layer::INVALID_ID instead of 0 for invalid layers in
WebScrollbarLayerImpl (patchset #1 id:1 of
https://codereview.chromium.org/2751973007/ )
> 
> Reason for revert:
> Possibly affecting CC_Unittests on Android.
> 
> TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FAndroid...
> 
> [ RUN      ]
TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer
> ../../cc/layers/texture_layer_unittest.cc:1195: Failure
> Value of: 5
> Expected: commit_count_
> Which is: 4
> [  FAILED  ]
TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer (25 ms)
> [----------] 1 test from TextureLayerChangeInvisibleMailboxTest (25 ms total)
> 
> 
> 
> Original issue's description:
> > Use Layer::INVALID_ID instead of 0 for invalid layers in
WebScrollbarLayerImpl
> > 
> > This patch fixes a bug where 0, a valid layer id, was used in place of an
> > invalid layer id in the constructor of WebScrollbarLayerImpl. This has
> > been split out of https://codereview.chromium.org/2728253002 which was
> > reverted.
> > 
> > BUG=693740
> > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> > 
> > Review-Url: https://codereview.chromium.org/2751973007
> > Cr-Commit-Position: refs/heads/master@{#457831}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/8ffd86e6c9e28bcab01a3f59fb28...
> 
> TBR=ajuma@chromium.org,pdr@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=693740
> 
> Review-Url: https://codereview.chromium.org/2757973002
> Cr-Commit-Position: refs/heads/master@{#457863}
> Committed:
https://chromium.googlesource.com/chromium/src/+/9655bcad1aa09a1dc837192866ca...

TBR=ajuma@chromium.org,nektar@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=693740
==========

to

==========
Reland of Use Layer::INVALID_ID instead of 0 for invalid layers in
WebScrollbarLayerImpl (patchset #1 id:1 of
https://codereview.chromium.org/2757973002/ )

Reason for revert:
Reverting this revert as the root cause was crbug.com/702868

Original issue's description:
> Revert of Use Layer::INVALID_ID instead of 0 for invalid layers in
WebScrollbarLayerImpl (patchset #1 id:1 of
https://codereview.chromium.org/2751973007/ )
> 
> Reason for revert:
> Possibly affecting CC_Unittests on Android.
> 
> TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FAndroid...
> 
> [ RUN      ]
TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer
> ../../cc/layers/texture_layer_unittest.cc:1195: Failure
> Value of: 5
> Expected: commit_count_
> Which is: 4
> [  FAILED  ]
TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer (25 ms)
> [----------] 1 test from TextureLayerChangeInvisibleMailboxTest (25 ms total)
> 
> 
> 
> Original issue's description:
> > Use Layer::INVALID_ID instead of 0 for invalid layers in
WebScrollbarLayerImpl
> > 
> > This patch fixes a bug where 0, a valid layer id, was used in place of an
> > invalid layer id in the constructor of WebScrollbarLayerImpl. This has
> > been split out of https://codereview.chromium.org/2728253002 which was
> > reverted.
> > 
> > BUG=693740
> > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> > 
> > Review-Url: https://codereview.chromium.org/2751973007
> > Cr-Commit-Position: refs/heads/master@{#457831}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/8ffd86e6c9e28bcab01a3f59fb28...
> 
> TBR=ajuma@chromium.org,pdr@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=693740
> 
> Review-Url: https://codereview.chromium.org/2757973002
> Cr-Commit-Position: refs/heads/master@{#457863}
> Committed:
https://chromium.googlesource.com/chromium/src/+/9655bcad1aa09a1dc837192866ca...

TBR=ajuma@chromium.org,nektar@chromium.org
BUG=693740
==========

[pdr., 2017-03-18 04:16:53]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2017-03-18 04:17:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-18 05:12:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489810613187880, "parent_rev":
"3b377cf1db6b26aff0789df18a59f532f4f82f6b", "commit_rev":
"4bed6671a93fb6d88d49cb8cd4136eb0257f1751"}

[commit-bot: I haz the power, 2017-03-18 05:14:51]

Description was changed from

==========
Reland of Use Layer::INVALID_ID instead of 0 for invalid layers in
WebScrollbarLayerImpl (patchset #1 id:1 of
https://codereview.chromium.org/2757973002/ )

Reason for revert:
Reverting this revert as the root cause was crbug.com/702868

Original issue's description:
> Revert of Use Layer::INVALID_ID instead of 0 for invalid layers in
WebScrollbarLayerImpl (patchset #1 id:1 of
https://codereview.chromium.org/2751973007/ )
> 
> Reason for revert:
> Possibly affecting CC_Unittests on Android.
> 
> TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FAndroid...
> 
> [ RUN      ]
TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer
> ../../cc/layers/texture_layer_unittest.cc:1195: Failure
> Value of: 5
> Expected: commit_count_
> Which is: 4
> [  FAILED  ]
TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer (25 ms)
> [----------] 1 test from TextureLayerChangeInvisibleMailboxTest (25 ms total)
> 
> 
> 
> Original issue's description:
> > Use Layer::INVALID_ID instead of 0 for invalid layers in
WebScrollbarLayerImpl
> > 
> > This patch fixes a bug where 0, a valid layer id, was used in place of an
> > invalid layer id in the constructor of WebScrollbarLayerImpl. This has
> > been split out of https://codereview.chromium.org/2728253002 which was
> > reverted.
> > 
> > BUG=693740
> > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> > 
> > Review-Url: https://codereview.chromium.org/2751973007
> > Cr-Commit-Position: refs/heads/master@{#457831}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/8ffd86e6c9e28bcab01a3f59fb28...
> 
> TBR=ajuma@chromium.org,pdr@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=693740
> 
> Review-Url: https://codereview.chromium.org/2757973002
> Cr-Commit-Position: refs/heads/master@{#457863}
> Committed:
https://chromium.googlesource.com/chromium/src/+/9655bcad1aa09a1dc837192866ca...

TBR=ajuma@chromium.org,nektar@chromium.org
BUG=693740
==========

to

==========
Reland of Use Layer::INVALID_ID instead of 0 for invalid layers in
WebScrollbarLayerImpl (patchset #1 id:1 of
https://codereview.chromium.org/2757973002/ )

Reason for revert:
Reverting this revert as the root cause was crbug.com/702868

Original issue's description:
> Revert of Use Layer::INVALID_ID instead of 0 for invalid layers in
WebScrollbarLayerImpl (patchset #1 id:1 of
https://codereview.chromium.org/2751973007/ )
> 
> Reason for revert:
> Possibly affecting CC_Unittests on Android.
> 
> TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FAndroid...
> 
> [ RUN      ]
TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer
> ../../cc/layers/texture_layer_unittest.cc:1195: Failure
> Value of: 5
> Expected: commit_count_
> Which is: 4
> [  FAILED  ]
TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer (25 ms)
> [----------] 1 test from TextureLayerChangeInvisibleMailboxTest (25 ms total)
> 
> 
> 
> Original issue's description:
> > Use Layer::INVALID_ID instead of 0 for invalid layers in
WebScrollbarLayerImpl
> > 
> > This patch fixes a bug where 0, a valid layer id, was used in place of an
> > invalid layer id in the constructor of WebScrollbarLayerImpl. This has
> > been split out of https://codereview.chromium.org/2728253002 which was
> > reverted.
> > 
> > BUG=693740
> > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> > 
> > Review-Url: https://codereview.chromium.org/2751973007
> > Cr-Commit-Position: refs/heads/master@{#457831}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/8ffd86e6c9e28bcab01a3f59fb28...
> 
> TBR=ajuma@chromium.org,pdr@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=693740
> 
> Review-Url: https://codereview.chromium.org/2757973002
> Cr-Commit-Position: refs/heads/master@{#457863}
> Committed:
https://chromium.googlesource.com/chromium/src/+/9655bcad1aa09a1dc837192866ca...

TBR=ajuma@chromium.org,nektar@chromium.org
BUG=693740

Review-Url: https://codereview.chromium.org/2756343002
Cr-Commit-Position: refs/heads/master@{#457958}
Committed:
https://chromium.googlesource.com/chromium/src/+/4bed6671a93fb6d88d49cb8cd413...
==========

[commit-bot: I haz the power, 2017-03-18 05:14:53]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4bed6671a93fb6d88d49cb8cd413...