Use Layer::INVALID_ID instead of 0 for invalid layers in WebScrollbarLayerImpl

Use Layer::INVALID_ID instead of 0 for invalid layers in WebScrollbarLayerImpl

This patch fixes a bug where 0, a valid layer id, was used in place of an
invalid layer id in the constructor of WebScrollbarLayerImpl. This has
been split out of https://codereview.chromium.org/2728253002 which was
reverted.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2751973007
Cr-Commit-Position: refs/heads/master@{#457831}
Committed: https://chromium.googlesource.com/chromium/src/+/8ffd86e6c9e28bcab01a3f59fb288a7f20df2090

[pdr., 2017-03-17 02:42:20]

Description was changed from

==========
Use Layer::INVALID_ID instead of 0 for invalid layers in WebScrollbarLayerImpl

This patch fixes a bug where 0, a valid layer id, was used in place of an
invalid layer id in the constructor of WebScrollbarLayerImpl. This has
been split out of https://codereview.chromium.org/2728253002 which was
reverted.

BUG=693740
==========

to

==========
Use Layer::INVALID_ID instead of 0 for invalid layers in WebScrollbarLayerImpl

This patch fixes a bug where 0, a valid layer id, was used in place of an
invalid layer id in the constructor of WebScrollbarLayerImpl. This has
been split out of https://codereview.chromium.org/2728253002 which was
reverted.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[pdr., 2017-03-17 02:42:42]

pdr@chromium.org changed reviewers:
+ ajuma@chromium.org

[pdr., 2017-03-17 02:42:53]

I manually confirmed this did not cause https://crbug.com/699504.

[pdr., 2017-03-17 02:42:56]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 02:43:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 03:35:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 03:35:48]

Dry run: This issue passed the CQ dry run.

[ajuma, 2017-03-17 13:04:33]

lgtm

[pdr., 2017-03-17 18:12:37]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2017-03-17 18:13:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 18:50:10]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489774357496550, "parent_rev":
"825f7ebf3ad0e14664fb91b80031a941747724b7", "commit_rev":
"8ffd86e6c9e28bcab01a3f59fb288a7f20df2090"}

[commit-bot: I haz the power, 2017-03-17 18:50:52]

Description was changed from

==========
Use Layer::INVALID_ID instead of 0 for invalid layers in WebScrollbarLayerImpl

This patch fixes a bug where 0, a valid layer id, was used in place of an
invalid layer id in the constructor of WebScrollbarLayerImpl. This has
been split out of https://codereview.chromium.org/2728253002 which was
reverted.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Use Layer::INVALID_ID instead of 0 for invalid layers in WebScrollbarLayerImpl

This patch fixes a bug where 0, a valid layer id, was used in place of an
invalid layer id in the constructor of WebScrollbarLayerImpl. This has
been split out of https://codereview.chromium.org/2728253002 which was
reverted.

BUG=693740
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2751973007
Cr-Commit-Position: refs/heads/master@{#457831}
Committed:
https://chromium.googlesource.com/chromium/src/+/8ffd86e6c9e28bcab01a3f59fb28...
==========

[commit-bot: I haz the power, 2017-03-17 18:50:54]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8ffd86e6c9e28bcab01a3f59fb28...

[nektarios, 2017-03-17 19:49:44]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2757973002/ by nektar@chromium.org.

The reason for reverting is: Possibly affecting CC_Unittests on Android.

TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FAndroid...

[ RUN      ]
TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer
../../cc/layers/texture_layer_unittest.cc:1195: Failure
Value of: 5
Expected: commit_count_
Which is: 4
[  FAILED  ]
TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer (25 ms)
[----------] 1 test from TextureLayerChangeInvisibleMailboxTest (25 ms total)

.