Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2757973002: Revert of Use Layer::INVALID_ID instead of 0 for invalid layers in WebScrollbarLayerImpl (Closed)

Created:
3 years, 9 months ago by nektarios
Modified:
3 years, 9 months ago
Reviewers:
ajuma, pdr.
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use Layer::INVALID_ID instead of 0 for invalid layers in WebScrollbarLayerImpl (patchset #1 id:1 of https://codereview.chromium.org/2751973007/ ) Reason for revert: Possibly affecting CC_Unittests on Android. TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FAndroid_Tests%2F39440%2F%2B%2Frecipes%2Fsteps%2Fcc_unittests_on_Android%2F0%2Flogs%2FTextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer%2F0 [ RUN ] TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer ../../cc/layers/texture_layer_unittest.cc:1195: Failure Value of: 5 Expected: commit_count_ Which is: 4 [ FAILED ] TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer (25 ms) [----------] 1 test from TextureLayerChangeInvisibleMailboxTest (25 ms total) Original issue's description: > Use Layer::INVALID_ID instead of 0 for invalid layers in WebScrollbarLayerImpl > > This patch fixes a bug where 0, a valid layer id, was used in place of an > invalid layer id in the constructor of WebScrollbarLayerImpl. This has > been split out of https://codereview.chromium.org/2728253002 which was > reverted. > > BUG=693740 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2751973007 > Cr-Commit-Position: refs/heads/master@{#457831} > Committed: https://chromium.googlesource.com/chromium/src/+/8ffd86e6c9e28bcab01a3f59fb288a7f20df2090 TBR=ajuma@chromium.org,pdr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=693740 Review-Url: https://codereview.chromium.org/2757973002 Cr-Commit-Position: refs/heads/master@{#457863} Committed: https://chromium.googlesource.com/chromium/src/+/9655bcad1aa09a1dc837192866ca8110c0d68563

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M cc/blink/web_scrollbar_layer_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
nektarios
Created Revert of Use Layer::INVALID_ID instead of 0 for invalid layers in WebScrollbarLayerImpl
3 years, 9 months ago (2017-03-17 19:49:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757973002/1
3 years, 9 months ago (2017-03-17 19:50:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/9655bcad1aa09a1dc837192866ca8110c0d68563
3 years, 9 months ago (2017-03-17 19:51:36 UTC) #6
pdr.
3 years, 9 months ago (2017-03-18 04:15:49 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2756343002/ by pdr@chromium.org.

The reason for reverting is: Reverting this revert as the root cause was
crbug.com/702868.

Powered by Google App Engine
This is Rietveld 408576698