Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2755853002: (re-land) Move ui/gfx/codec/ into its own component. (Closed)

Created:
3 years, 9 months ago by chrishtr
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

(re-land) Move ui/gfx/codec/ into its own component. This is necessary to break an include cycle between cc and ui/gfx/ for upcoming changes to cc/paint/. Fixes export macro for jpeg_codec_robust_slow.h, which was wrong in https://codereview.chromium.org/2755563002 (original land). TBR=robertphillips@google.com,sky,rockot BUG=665259 Review-Url: https://codereview.chromium.org/2755853002 Cr-Commit-Position: refs/heads/master@{#457328} Committed: https://chromium.googlesource.com/chromium/src/+/2af80fb776a74459de063b92535fc5f5068a413f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -583 lines) Patch
M services/image_decoder/image_decoder_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/BUILD.gn View 7 chunks +2 lines, -26 lines 0 comments Download
D ui/gfx/chromeos/codec/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D ui/gfx/chromeos/codec/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D ui/gfx/chromeos/codec/jpeg_codec_robust_slow.h View 1 chunk +0 lines, -56 lines 0 comments Download
D ui/gfx/chromeos/codec/jpeg_codec_robust_slow.cc View 1 chunk +0 lines, -343 lines 0 comments Download
D ui/gfx/chromeos/codec/jpeg_codec_robust_slow_unittest.cc View 1 chunk +0 lines, -108 lines 0 comments Download
A ui/gfx/codec/BUILD.gn View 1 chunk +51 lines, -0 lines 0 comments Download
A + ui/gfx/codec/chromeos/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/codec/chromeos/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/gfx/codec/chromeos/jpeg_codec_robust_slow.h View 4 chunks +11 lines, -8 lines 0 comments Download
A + ui/gfx/codec/chromeos/jpeg_codec_robust_slow.cc View 7 chunks +15 lines, -17 lines 0 comments Download
A + ui/gfx/codec/chromeos/jpeg_codec_robust_slow_unittest.cc View 2 chunks +7 lines, -11 lines 0 comments Download
A ui/gfx/codec/codec_export.h View 1 chunk +29 lines, -0 lines 0 comments Download
M ui/gfx/codec/jpeg_codec.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/codec/png_codec.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/codec/skia_image_encoder_adapter.h View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (10 generated)
chrishtr
Confirmed that linux_chromium_chromeos_compile_rel_ng succeeds this time.
3 years, 9 months ago (2017-03-16 02:17:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755853002/1
3 years, 9 months ago (2017-03-16 02:18:25 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 02:45:28 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2af80fb776a74459de063b92535f...

Powered by Google App Engine
This is Rietveld 408576698