[Web Payments] Consolidate list code.

[Web Payments] Consolidate list code.

BUG=697084
TEST=unit_tests, browsertests, all sheets still display fine

Review-Url: https://codereview.chromium.org/2755493005
Cr-Commit-Position: refs/heads/master@{#458078}
Committed: https://chromium.googlesource.com/chromium/src/+/2aefe36d7f1e07679eb91dd2b7f9146e079c9bb2

[anthonyvd, 2017-03-16 16:03:26]

anthonyvd@chromium.org changed reviewers:
+ tmartino@chromium.org

[anthonyvd, 2017-03-16 16:03:27]

Hi Tommy, this is another refactor of the list sheets that follows up on yours
and puts more common stuff in the base class.

Can you PTAL? Thanks!

[tmartino, 2017-03-16 17:42:01]

lgtm

https://codereview.chromium.org/2755493005/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/payment_request_item_list.cc (right):

https://codereview.chromium.org/2755493005/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_request_item_list.cc:84: // Add a
column listing the profile information.
nit: This class is not associated with a profile

https://codereview.chromium.org/2755493005/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/shipping_option_view_controller.cc
(right):

https://codereview.chromium.org/2755493005/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/shipping_option_view_controller.cc:37: //
Shipping options are vetted by the website, they're all OK to select.
Omega nit: this should be a semicolon, not a comma ;)

[anthonyvd, 2017-03-20 13:24:59]

https://codereview.chromium.org/2755493005/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/payment_request_item_list.cc (right):

https://codereview.chromium.org/2755493005/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/payment_request_item_list.cc:84: // Add a
column listing the profile information.
On 2017/03/16 at 17:42:01, tmartino wrote:
> nit: This class is not associated with a profile

Good catch, done!

https://codereview.chromium.org/2755493005/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/payments/shipping_option_view_controller.cc
(right):

https://codereview.chromium.org/2755493005/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/payments/shipping_option_view_controller.cc:37: //
Shipping options are vetted by the website, they're all OK to select.
On 2017/03/16 at 17:42:01, tmartino wrote:
> Omega nit: this should be a semicolon, not a comma ;)

Done!

[anthonyvd, 2017-03-20 13:25:05]

The CQ bit was checked by anthonyvd@chromium.org

[anthonyvd, 2017-03-20 13:25:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
tmartino@chromium.org
Link to the patchset: https://codereview.chromium.org/2755493005/#ps40001
(title: "Fix and add comments.")

[commit-bot: I haz the power, 2017-03-20 13:25:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 13:27:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 13:27:50]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[anthonyvd, 2017-03-20 14:48:52]

The CQ bit was checked by anthonyvd@chromium.org

[anthonyvd, 2017-03-20 14:48:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
tmartino@chromium.org
Link to the patchset: https://codereview.chromium.org/2755493005/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-20 14:49:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 14:58:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 14:58:19]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[anthonyvd, 2017-03-20 15:19:14]

The CQ bit was checked by anthonyvd@chromium.org

[anthonyvd, 2017-03-20 15:19:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
tmartino@chromium.org
Link to the patchset: https://codereview.chromium.org/2755493005/#ps80001
(title: "Fix test compile.")

[commit-bot: I haz the power, 2017-03-20 15:19:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 16:06:50]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490023154027650,
"parent_rev": "e44e87cea4e3f1106e785f794f5a9d51fb0ed273", "commit_rev":
"2aefe36d7f1e07679eb91dd2b7f9146e079c9bb2"}

[commit-bot: I haz the power, 2017-03-20 16:07:30]

Description was changed from

==========
[Web Payments] Consolidate list code.

BUG=697084
TEST=unit_tests, browsertests, all sheets still display fine
==========

to

==========
[Web Payments] Consolidate list code.

BUG=697084
TEST=unit_tests, browsertests, all sheets still display fine

Review-Url: https://codereview.chromium.org/2755493005
Cr-Commit-Position: refs/heads/master@{#458078}
Committed:
https://chromium.googlesource.com/chromium/src/+/2aefe36d7f1e07679eb91dd2b7f9...
==========

[commit-bot: I haz the power, 2017-03-20 16:07:31]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/2aefe36d7f1e07679eb91dd2b7f9...