[Web Payments] Consolidate list code.

chrome/browser/ui/views/payments/shipping_option_view_controller.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/payments/shipping_option_view_controller.h"
 
 #include "chrome/browser/ui/views/payments/payment_request_views_util.h"
 #include "components/payments/content/payment_request_spec.h"
 #include "components/payments/content/payment_request_state.h"
 
 namespace payments {
 
 namespace {
 
 class ShippingOptionItem : public PaymentRequestItemList::Item {
  public:
   ShippingOptionItem(payments::mojom::PaymentShippingOption* shipping_option,
                      PaymentRequestSpec* spec,
                      PaymentRequestState* state,
                      PaymentRequestItemList* parent_list,
                      bool selected)
       : PaymentRequestItemList::Item(spec, state, parent_list, selected),
         shipping_option_(shipping_option) {}
   ~ShippingOptionItem() override {}
 
  private:
   // payments::PaymentRequestItemList::Item:
-  std::unique_ptr<views::View> CreateItemView() override {
+  std::unique_ptr<views::View> CreateContentView() override {
     return CreateShippingOptionLabel(
         shipping_option_,
         spec()->GetFormattedCurrencyAmount(shipping_option_->amount->value));
   }
 
   void SelectedStateChanged() override {}
 
+  bool CanBeSelected() const override {
+    // Shipping options are vetted by the website, they're all OK to select.

[tmartino, 2017/03/16 17:42:01]

Omega nit: this should be a semicolon, not a comma ;)

[anthonyvd, 2017/03/20 13:24:59]

Done!

+    return true;
+  }
+
+  void PerformSelectionFallback() override {
+    // Since CanBeSelected() is always true, this should never be called.
+    NOTREACHED();
+  }
+
   mojom::PaymentShippingOption* shipping_option_;
 
   DISALLOW_COPY_AND_ASSIGN(ShippingOptionItem);
 };
 
 }  // namespace
 
 ShippingOptionViewController::ShippingOptionViewController(
     PaymentRequestSpec* spec,
     PaymentRequestState* state,
@@ skipping 17 matching lines @@
           this),
       std::move(list_view));
 }
 
 std::unique_ptr<views::View>
 ShippingOptionViewController::CreateExtraFooterView() {
   return nullptr;
 }
 
 }  // namespace payments