Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: chrome/browser/ui/views/payments/profile_list_view_controller.cc

Issue 2755493005: [Web Payments] Consolidate list code. (Closed)
Patch Set: Fix test compile. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/profile_list_view_controller.cc
diff --git a/chrome/browser/ui/views/payments/profile_list_view_controller.cc b/chrome/browser/ui/views/payments/profile_list_view_controller.cc
index 65cf330826a8c6ddf8f2c4bf4a283e35969a790e..02d4b5cd0c973f43a0b6f41b00d44e0329e4eec8 100644
--- a/chrome/browser/ui/views/payments/profile_list_view_controller.cc
+++ b/chrome/browser/ui/views/payments/profile_list_view_controller.cc
@@ -10,8 +10,6 @@
#include "components/payments/content/payment_request_state.h"
#include "components/strings/grit/components_strings.h"
#include "ui/base/l10n/l10n_util.h"
-#include "ui/views/controls/image_view.h"
-#include "ui/views/layout/grid_layout.h"
namespace payments {
@@ -41,47 +39,25 @@ class ProfileItem : public PaymentRequestItemList::Item {
private:
// payments::PaymentRequestItemList::Item:
- std::unique_ptr<views::View> CreateItemView() override {
+ std::unique_ptr<views::View> CreateContentView() override {
DCHECK(profile_);
- std::unique_ptr<views::View> content = parent_view_->GetLabel(profile_);
-
- std::unique_ptr<PaymentRequestRowView> row =
- base::MakeUnique<PaymentRequestRowView>(this);
- views::GridLayout* layout = new views::GridLayout(row.get());
- row->SetLayoutManager(layout);
-
- layout->SetInsets(
- kPaymentRequestRowVerticalInsets, kPaymentRequestRowHorizontalInsets,
- kPaymentRequestRowVerticalInsets,
- kPaymentRequestRowHorizontalInsets + kPaymentRequestRowExtraRightInset);
-
- // Add a column listing the profile information.
- views::ColumnSet* columns = layout->AddColumnSet(0);
- columns->AddColumn(views::GridLayout::FILL, views::GridLayout::LEADING, 1,
- views::GridLayout::USE_PREF, 0, 0);
-
- columns->AddPaddingColumn(1, 0);
-
- // Add a column for the checkmark shown next to the selected profile.
- columns->AddColumn(views::GridLayout::TRAILING, views::GridLayout::CENTER,
- 0, views::GridLayout::USE_PREF, 0, 0);
-
- layout->StartRow(0, 0);
- content->set_can_process_events_within_subtree(false);
- layout->AddView(content.release());
+ return parent_view_->GetLabel(profile_);
+ }
- checkmark_ = CreateCheckmark(selected());
- layout->AddView(checkmark_.get());
+ void SelectedStateChanged() override {}
- return std::move(row);
+ bool CanBeSelected() const override {
+ // TODO(anthonyvd): Check for profile completedness.
+ return true;
}
- void SelectedStateChanged() override {}
+ void PerformSelectionFallback() override {
+ // TODO(anthonyvd): Open the editor pre-populated with this profile's data.
+ }
ProfileListViewController* parent_view_;
autofill::AutofillProfile* profile_;
- std::unique_ptr<views::ImageView> checkmark_;
DISALLOW_COPY_AND_ASSIGN(ProfileItem);
};

Powered by Google App Engine
This is Rietveld 408576698