Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Issue 2755273002: Reland of Disable swipe down to enter the tab switcher in Chrome Home. (Closed)

Created:
3 years, 9 months ago by Ted C
Modified:
3 years, 9 months ago
Reviewers:
mdjones, nektarios
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Disable swipe down to enter the tab switcher in Chrome Home. (patchset #1 id:1 of https://codereview.chromium.org/2761463004/ ) Reason for revert: Since this affects entering the tab switcher on user gesture (and only if a chrome flag is turned on), I'm pretty sure this was not the underlying cause. Most likely some transient issue that caused all the devices to go offline or be unreachable. There was this in the logs that I got from jbudorick@ NoDevicesError: No devices attached. Original issue's description: > Revert of Disable swipe down to enter the tab switcher in Chrome Home. (patchset #1 id:1 of https://codereview.chromium.org/2755823004/ ) > > Reason for revert: > Possibly broke multiple tests on Android concerning e.g. opening tabs. > https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/40909 > > > Original issue's description: > > Disable swipe down to enter the tab switcher in Chrome Home. > > > > BUG= > > > > Review-Url: https://codereview.chromium.org/2755823004 > > Cr-Commit-Position: refs/heads/master@{#457836} > > Committed: https://chromium.googlesource.com/chromium/src/+/f3b96a7b630ef08149c29ffab26a70df8d54f6d8 > > TBR=mdjones@chromium.org,tedchoc@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Review-Url: https://codereview.chromium.org/2761463004 > Cr-Commit-Position: refs/heads/master@{#457889} > Committed: https://chromium.googlesource.com/chromium/src/+/0e89702abe2235bfb1bc778444d2eb2f166567ad TBR=mdjones@chromium.org,nektar@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2755273002 Cr-Commit-Position: refs/heads/master@{#457904} Committed: https://chromium.googlesource.com/chromium/src/+/af74c4fbb6b0c2484f6774febaf58a01c0f0ef38

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java View 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java View 4 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Ted C
Created Reland of Disable swipe down to enter the tab switcher in Chrome Home.
3 years, 9 months ago (2017-03-17 23:33:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755273002/1
3 years, 9 months ago (2017-03-17 23:34:37 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 23:36:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/af74c4fbb6b0c2484f6774febaf5...

Powered by Google App Engine
This is Rietveld 408576698