Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2755823004: Disable swipe down to enter the tab switcher in Chrome Home. (Closed)

Created:
3 years, 9 months ago by Ted C
Modified:
3 years, 9 months ago
Reviewers:
mdjones
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable swipe down to enter the tab switcher in Chrome Home. BUG= Review-Url: https://codereview.chromium.org/2755823004 Cr-Commit-Position: refs/heads/master@{#457836} Committed: https://chromium.googlesource.com/chromium/src/+/f3b96a7b630ef08149c29ffab26a70df8d54f6d8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java View 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java View 4 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Ted C
PTAL!
3 years, 9 months ago (2017-03-17 16:11:53 UTC) #2
mdjones
lgtm
3 years, 9 months ago (2017-03-17 17:48:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755823004/1
3 years, 9 months ago (2017-03-17 18:04:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f3b96a7b630ef08149c29ffab26a70df8d54f6d8
3 years, 9 months ago (2017-03-17 18:58:39 UTC) #8
nektarios
3 years, 9 months ago (2017-03-17 21:28:34 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2761463004/ by nektar@chromium.org.

The reason for reverting is: Possibly broke multiple tests on Android concerning
e.g. opening tabs.
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg...
.

Powered by Google App Engine
This is Rietveld 408576698