Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2761463004: Revert of Disable swipe down to enter the tab switcher in Chrome Home. (Closed)

Created:
3 years, 9 months ago by nektarios
Modified:
3 years, 9 months ago
Reviewers:
mdjones, Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable swipe down to enter the tab switcher in Chrome Home. (patchset #1 id:1 of https://codereview.chromium.org/2755823004/ ) Reason for revert: Possibly broke multiple tests on Android concerning e.g. opening tabs. https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/40909 Original issue's description: > Disable swipe down to enter the tab switcher in Chrome Home. > > BUG= > > Review-Url: https://codereview.chromium.org/2755823004 > Cr-Commit-Position: refs/heads/master@{#457836} > Committed: https://chromium.googlesource.com/chromium/src/+/f3b96a7b630ef08149c29ffab26a70df8d54f6d8 TBR=mdjones@chromium.org,tedchoc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2761463004 Cr-Commit-Position: refs/heads/master@{#457889} Committed: https://chromium.googlesource.com/chromium/src/+/0e89702abe2235bfb1bc778444d2eb2f166567ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -30 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java View 2 chunks +6 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java View 4 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
nektarios
Created Revert of Disable swipe down to enter the tab switcher in Chrome Home.
3 years, 9 months ago (2017-03-17 21:28:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761463004/1
3 years, 9 months ago (2017-03-17 21:29:11 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0e89702abe2235bfb1bc778444d2eb2f166567ad
3 years, 9 months ago (2017-03-17 21:30:43 UTC) #6
Ted C
3 years, 9 months ago (2017-03-17 23:33:50 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2755273002/ by tedchoc@chromium.org.

The reason for reverting is: Since this affects entering the tab switcher on
user gesture (and only if a chrome flag is turned on), I'm pretty sure this was
not the underlying cause.

Most likely some transient issue that caused all the devices to go offline or be
unreachable.

There was this in the logs that I got from jbudorick@
NoDevicesError: No devices attached..

Powered by Google App Engine
This is Rietveld 408576698