Issue 275493004: Rename from "(un)lock" to "(un)map" for geometry buffers.

Issue 275493004: Rename from "(un)lock" to "(un)map" for geometry buffers. (Closed)

Created:
6 years, 7 months ago by bsalomon

Modified:
6 years, 7 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Rename from "(un)lock" to "(un)map" for geometry buffers. This better reflects OpenGL terminology and is less overloaded ("lock" is used w.r.t. the resource cache). Committed: http://code.google.com/p/skia/source/detail?r=14628

Patch Set 1 #

Total comments: 4

Patch Set 2 : remove extra newlines in GrContext.h #

Patch Set 3 : Address Rob's comments #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1207 lines, -1207 lines)			Patch
M	include/gpu/GrConfig.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	include/gpu/GrUserConfig.h	View		1 chunk	+34 lines, -34 lines	0 comments	Download
M	src/gpu/GrAAHairLinePathRenderer.cpp	View		1 chunk	+1042 lines, -1042 lines	0 comments	Download
M	src/gpu/GrAARectRenderer.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/gpu/GrBufferAllocPool.h	View		8 chunks	+12 lines, -12 lines	0 comments	Download
M	src/gpu/GrBufferAllocPool.cpp	View	1 2	9 chunks	+32 lines, -32 lines	0 comments	Download
M	src/gpu/GrGeometryBuffer.h	View		1 chunk	+20 lines, -20 lines	0 comments	Download
M	src/gpu/GrGpu.h	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/gpu/GrGpu.cpp	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGLBufferImpl.h	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/gpu/gl/GrGLBufferImpl.cpp	View		9 chunks	+20 lines, -20 lines	0 comments	Download
M	src/gpu/gl/GrGLIndexBuffer.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/gpu/gl/GrGLIndexBuffer.cpp	View		1 chunk	+8 lines, -8 lines	0 comments	Download
M	src/gpu/gl/GrGLVertexBuffer.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/gpu/gl/GrGLVertexBuffer.cpp	View		1 chunk	+8 lines, -8 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL_program.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

bsalomon

It's also more consistent with what we call the feature in the caps classes.

6 years, 7 months ago (2014-05-07 19:55:56 UTC) #1

robertphillips

lgtm - I think the map/unmap naming is far better. https://codereview.chromium.org/275493004/diff/1/src/gpu/GrBufferAllocPool.cpp File src/gpu/GrBufferAllocPool.cpp (right): https://codereview.chromium.org/275493004/diff/1/src/gpu/GrBufferAllocPool.cpp#newcode123 ...

6 years, 7 months ago (2014-05-07 20:01:26 UTC) #2

bsalomon

https://codereview.chromium.org/275493004/diff/1/src/gpu/GrBufferAllocPool.cpp File src/gpu/GrBufferAllocPool.cpp (right): https://codereview.chromium.org/275493004/diff/1/src/gpu/GrBufferAllocPool.cpp#newcode123 src/gpu/GrBufferAllocPool.cpp:123: SkASSERT(!fBlocks.empty()); On 2014/05/07 20:01:26, robertphillips wrote: > ! ? ...

6 years, 7 months ago (2014-05-07 20:44:20 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/275493004/40001

6 years, 7 months ago (2014-05-07 20:44:56 UTC) #5

Message was sent while issue was closed.

Change committed as 14628

Expand Messages | Collapse Messages