Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2754763002: [Bindings] Fix presubmit run-bindings-tests failure (Closed)

Created:
3 years, 9 months ago by peria
Modified:
3 years, 9 months ago
Reviewers:
alph, bashi
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix presubmit run-bindings-tests failure This issue was introduced by https://codereview.chromium.org/2748383002 which renames InspectorInstrumentation.idl to InstrumentingProbes.idl. I wonder why presubmit check did not fail in the CL. BUG=None Review-Url: https://codereview.chromium.org/2754763002 Cr-Commit-Position: refs/heads/master@{#457360} Committed: https://chromium.googlesource.com/chromium/src/+/7bc81aa962629e0b6e3f6cae86bf650bdaf7f410

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/bindings/bindings_tests.py View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
peria
PTL
3 years, 9 months ago (2017-03-16 04:37:39 UTC) #3
bashi
lgtm (Maybe InstrumentingProbes.idl should have different suffix as it's not a valid IDL file)
3 years, 9 months ago (2017-03-16 04:41:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754763002/1
3 years, 9 months ago (2017-03-16 04:42:42 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 05:57:59 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7bc81aa962629e0b6e3f6cae86bf...

Powered by Google App Engine
This is Rietveld 408576698