[instrumentation] Generate instrumentation probes with jinja2

[instrumentation] Generate instrumentation probes with jinja2

BUG=695625
Review-Url: https://codereview.chromium.org/2748383002
Cr-Commit-Position: refs/heads/master@{#457321}
Committed: https://chromium.googlesource.com/chromium/src/+/cf59a89caec7659dae0a166d61185f7b6cfb0bf0

[alph, 2017-03-15 20:52:33]

alph@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[alph, 2017-03-15 20:53:18]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 20:54:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 22:42:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 22:43:00]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dgozman, 2017-03-15 23:04:46]

Let's follow-up with moving more logic out of python script.

lgtm

https://codereview.chromium.org/2748383002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InstrumentingAgents_h.template
(right):

https://codereview.chromium.org/2748383002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InstrumentingAgents_h.template:40: bool
m_has{{class_name}} = false;
m_has{{class_name}}s ?

https://codereview.chromium.org/2748383002/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/inspector/InstrumentingProbesImpl_cpp.template
(right):

https://codereview.chromium.org/2748383002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InstrumentingProbesImpl_cpp.template:29:
{% macro probe_body(probe, common_name, agent_arguments) %}
agent_arguments is unused

https://codereview.chromium.org/2748383002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InstrumentingProbesImpl_cpp.template:40:
RefPtr<{{param.inner_type}}> {{param.value}} = {{param.name}};
Note this probably does not work if we have more than one agent in probe.

[alph, 2017-03-16 00:12:56]

https://codereview.chromium.org/2748383002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InstrumentingAgents_h.template
(right):

https://codereview.chromium.org/2748383002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InstrumentingAgents_h.template:40: bool
m_has{{class_name}} = false;
On 2017/03/15 23:04:45, dgozman wrote:
> m_has{{class_name}}s ?

Done.

https://codereview.chromium.org/2748383002/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/inspector/InstrumentingProbesImpl_cpp.template
(right):

https://codereview.chromium.org/2748383002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InstrumentingProbesImpl_cpp.template:29:
{% macro probe_body(probe, common_name, agent_arguments) %}
On 2017/03/15 23:04:45, dgozman wrote:
> agent_arguments is unused

Done.

https://codereview.chromium.org/2748383002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InstrumentingProbesImpl_cpp.template:40:
RefPtr<{{param.inner_type}}> {{param.value}} = {{param.name}};
On 2017/03/15 23:04:45, dgozman wrote:
> Note this probably does not work if we have more than one agent in probe.

Done.

[alph, 2017-03-16 00:14:55]

The CQ bit was checked by alph@chromium.org

[alph, 2017-03-16 00:14:55]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2748383002/#ps20001
(title: "addressing comments")

[commit-bot: I haz the power, 2017-03-16 00:15:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 02:27:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489623295281060,
"parent_rev": "8db424fb7191b2be7b58b89427b9b258d057d97b", "commit_rev":
"cf59a89caec7659dae0a166d61185f7b6cfb0bf0"}

[commit-bot: I haz the power, 2017-03-16 02:28:26]

Description was changed from

==========
[instrumentation] Generate instrumentation probes with jinja2

BUG=695625
==========

to

==========
[instrumentation] Generate instrumentation probes with jinja2

BUG=695625

Review-Url: https://codereview.chromium.org/2748383002
Cr-Commit-Position: refs/heads/master@{#457321}
Committed:
https://chromium.googlesource.com/chromium/src/+/cf59a89caec7659dae0a166d6118...
==========

[commit-bot: I haz the power, 2017-03-16 02:28:27]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cf59a89caec7659dae0a166d6118...