[Refactoring] Clean up binding template files for callback interfaces

Clean up binding template files for callback interfaces

This CL does
- replaces m_scriptState->isolate() with an isolate pointer
- uses executionContext pointer
- folds not-parametarized long lines


BUG=660281
Review-Url: https://codereview.chromium.org/2758463002
Cr-Commit-Position: refs/heads/master@{#457372}
Committed: https://chromium.googlesource.com/chromium/src/+/ff8bf75385335e8da5261a179e70af52f2af5c49

[peria, 2017-03-16 05:23:53]

Description was changed from

==========
Refactoring of callback interface templates

BUG=
==========

to

==========
Clean up binding template files for callback interfaces

This CL does
- replaces m_scriptState->isolate() with an isolate pointer
- folds static and long lines
- removes EXPORT macro on private constructors in .h files


BUG=660281
==========

[peria, 2017-03-16 05:25:35]

The CQ bit was checked by peria@chromium.org to run a CQ dry run

[peria, 2017-03-16 05:25:43]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-03-16 05:25:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[peria, 2017-03-16 05:28:10]

Description was changed from

==========
Clean up binding template files for callback interfaces

This CL does
- replaces m_scriptState->isolate() with an isolate pointer
- folds static and long lines
- removes EXPORT macro on private constructors in .h files


BUG=660281
==========

to

==========
Clean up binding template files for callback interfaces

This CL does
- replaces m_scriptState->isolate() with an isolate pointer
- uses executionContext pointer
- folds not-parametarized long lines
- removes EXPORT macro on private constructors in .h files


BUG=660281
==========

[peria, 2017-03-16 05:28:44]

peria@chromium.org changed reviewers:
+ bashi@chromium.org, haraken@chromium.org, yukishiino@chromium.org

[peria, 2017-03-16 05:28:44]

PTL

[bashi, 2017-03-16 05:30:42]

lgtm

[commit-bot: I haz the power, 2017-03-16 05:48:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 05:48:56]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[peria, 2017-03-16 06:27:39]

Description was changed from

==========
Clean up binding template files for callback interfaces

This CL does
- replaces m_scriptState->isolate() with an isolate pointer
- uses executionContext pointer
- folds not-parametarized long lines
- removes EXPORT macro on private constructors in .h files


BUG=660281
==========

to

==========
Clean up binding template files for callback interfaces

This CL does
- replaces m_scriptState->isolate() with an isolate pointer
- uses executionContext pointer
- folds not-parametarized long lines
- moves EXPORT macro from private constructor to public create method


BUG=660281
==========

[peria, 2017-03-16 06:27:52]

The CQ bit was checked by peria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 06:28:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[peria, 2017-03-16 06:34:34]

The CQ bit was unchecked by peria@chromium.org

[peria, 2017-03-16 06:35:48]

Description was changed from

==========
Clean up binding template files for callback interfaces

This CL does
- replaces m_scriptState->isolate() with an isolate pointer
- uses executionContext pointer
- folds not-parametarized long lines
- moves EXPORT macro from private constructor to public create method


BUG=660281
==========

to

==========
Clean up binding template files for callback interfaces

This CL does
- replaces m_scriptState->isolate() with an isolate pointer
- uses executionContext pointer
- folds not-parametarized long lines
- moves EXPORT macro from private constructor to public create method
- moves implementation of create method from .h file to .cpp file


BUG=660281
==========

[peria, 2017-03-16 06:38:44]

Description was changed from

==========
Clean up binding template files for callback interfaces

This CL does
- replaces m_scriptState->isolate() with an isolate pointer
- uses executionContext pointer
- folds not-parametarized long lines
- moves EXPORT macro from private constructor to public create method
- moves implementation of create method from .h file to .cpp file


BUG=660281
==========

to

==========
Clean up binding template files for callback interfaces

This CL does
- replaces m_scriptState->isolate() with an isolate pointer
- uses executionContext pointer
- folds not-parametarized long lines


BUG=660281
==========

[peria, 2017-03-16 06:39:29]

The CQ bit was checked by peria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 06:39:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[peria, 2017-03-16 06:45:44]

PTAL.

I tried to move {{exported}} in .h file from private constructor
to public create() method, but it failed in component builds.
We can do it with moving create()'s implementation to .cpp.tmpl
file, but I'd like keep it as-is.

[Yuki, 2017-03-16 07:02:50]

LGTM.

[peria, 2017-03-16 07:05:20]

The CQ bit was unchecked by peria@chromium.org

[peria, 2017-03-16 07:05:21]

The CQ bit was checked by peria@chromium.org

[peria, 2017-03-16 07:05:22]

The patchset sent to the CQ was uploaded after l-g-t-m from bashi@chromium.org
Link to the patchset: https://codereview.chromium.org/2758463002/#ps70001
(title: ".")

[commit-bot: I haz the power, 2017-03-16 07:05:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 08:28:49]

CQ is committing da patch.

Bot data: {"patchset_id": 70001, "attempt_start_ts": 1489647921641940,
"parent_rev": "504f5aa7b3a47722ab1b5e90a02378814b7ac96e", "commit_rev":
"ff8bf75385335e8da5261a179e70af52f2af5c49"}

[commit-bot: I haz the power, 2017-03-16 08:29:30]

Description was changed from

==========
Clean up binding template files for callback interfaces

This CL does
- replaces m_scriptState->isolate() with an isolate pointer
- uses executionContext pointer
- folds not-parametarized long lines


BUG=660281
==========

to

==========
Clean up binding template files for callback interfaces

This CL does
- replaces m_scriptState->isolate() with an isolate pointer
- uses executionContext pointer
- folds not-parametarized long lines


BUG=660281

Review-Url: https://codereview.chromium.org/2758463002
Cr-Commit-Position: refs/heads/master@{#457372}
Committed:
https://chromium.googlesource.com/chromium/src/+/ff8bf75385335e8da5261a179e70...
==========

[commit-bot: I haz the power, 2017-03-16 08:29:31]

Committed patchset #4 (id:70001) as
https://chromium.googlesource.com/chromium/src/+/ff8bf75385335e8da5261a179e70...

[haraken, 2017-03-16 08:32:01]

LGTM