Remove Gradient point/radius setters

Remove Gradient point/radius setters

These are only called from CSSGradientValue to adjust the points/radii
immediately after Gradient instantiation.

Refactor CSSGradientValue to perform the adjustment before constructing
the Gradient object.  No functional changes.

BUG=614368
R=schenney@chromium.org,fs@opera.com

Review-Url: https://codereview.chromium.org/2754703003
Cr-Commit-Position: refs/heads/master@{#457498}
Committed: https://chromium.googlesource.com/chromium/src/+/a1f25a6c5efe6eaf1f5fd5d32593f60e4586e6fe

[f(malita), 2017-03-16 16:19:20]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 16:19:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2017-03-16 17:21:04]

Description was changed from

==========
Remove Gradient point/radius setters

These are only called from CSSGradientValue to adjust the points/radii
immediately after Gradient instantiation.

Refactor CSSGradientValue to perform the adjustment before constructing
the Gradient object.

BUG=614368
R=schenney@chromium.org,fs@opera.com
==========

to

==========
Remove Gradient point/radius setters

These are only called from CSSGradientValue to adjust the points/radii
immediately after Gradient instantiation.

Refactor CSSGradientValue to perform the adjustment before constructing
the Gradient object.  No functional changes.

BUG=614368
R=schenney@chromium.org,fs@opera.com
==========

[f(malita), 2017-03-16 17:37:23]

With this change, CSS gradient stops are copied to an intermediate vector.  This
should be a temporary (and hopefully negligible) overhead because

a) the end game is to pass the color stops to the Gradient ctor/shader builder,
and no longer store in Gradient

b) short term I have some ideas how to refactor color stops management to allow
moving into Gradient (instead of copying)

[commit-bot: I haz the power, 2017-03-16 17:49:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 17:49:43]

Dry run: This issue passed the CQ dry run.

[Stephen Chennney, 2017-03-16 18:06:26]

On 2017/03/16 17:37:23, f(malita) wrote:
> With this change, CSS gradient stops are copied to an intermediate vector. 
This
> should be a temporary (and hopefully negligible) overhead because
> 
> a) the end game is to pass the color stops to the Gradient ctor/shader
builder,
> and no longer store in Gradient
> 
> b) short term I have some ideas how to refactor color stops management to
allow
> moving into Gradient (instead of copying)

Thanks for the note, as it explains why it is this way. lgtm.

[f(malita), 2017-03-16 18:13:50]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2017-03-16 18:14:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 18:24:32]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489688030523880, "parent_rev":
"38c960952a3a5b5988c6bbae897451065202d250", "commit_rev":
"a1f25a6c5efe6eaf1f5fd5d32593f60e4586e6fe"}

[commit-bot: I haz the power, 2017-03-16 18:25:09]

Description was changed from

==========
Remove Gradient point/radius setters

These are only called from CSSGradientValue to adjust the points/radii
immediately after Gradient instantiation.

Refactor CSSGradientValue to perform the adjustment before constructing
the Gradient object.  No functional changes.

BUG=614368
R=schenney@chromium.org,fs@opera.com
==========

to

==========
Remove Gradient point/radius setters

These are only called from CSSGradientValue to adjust the points/radii
immediately after Gradient instantiation.

Refactor CSSGradientValue to perform the adjustment before constructing
the Gradient object.  No functional changes.

BUG=614368
R=schenney@chromium.org,fs@opera.com

Review-Url: https://codereview.chromium.org/2754703003
Cr-Commit-Position: refs/heads/master@{#457498}
Committed:
https://chromium.googlesource.com/chromium/src/+/a1f25a6c5efe6eaf1f5fd5d32593...
==========

[commit-bot: I haz the power, 2017-03-16 18:25:10]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a1f25a6c5efe6eaf1f5fd5d32593...