Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2754783003: Remove two Gradient setters (Closed)

Created:
3 years, 9 months ago by f(malita)
Modified:
3 years, 9 months ago
Reviewers:
Stephen Chennney, fs
CC:
fs, ajuma+watch_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, fmalita+watch_chromium.org, gyuyoung2, jbroman, jchaffraix+rendering, Justin Novosad, kinuko+watch, kouhei+svg_chromium.org, leviw+renderwatch, pdr+graphicswatchlist_chromium.org, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, reed1, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove two Gradient setters setSpreadMethod() and setDrawsInPMColorSpace() are only ever called immediately after instantiation, so they can be folded into ctor easily. Refactor only, no functional changes. BUG=614368 R=schenney@chromium.org,fs@opera.com Review-Url: https://codereview.chromium.org/2754783003 Cr-Commit-Position: refs/heads/master@{#457473} Committed: https://chromium.googlesource.com/chromium/src/+/b857e84f42f1571295105ce453467c0d24594a90

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -67 lines) Patch
M third_party/WebKit/Source/core/css/CSSGradientValue.cpp View 2 chunks +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceRadialGradient.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Gradient.h View 3 chunks +29 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Gradient.cpp View 7 chunks +19 lines, -35 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (6 generated)
f(malita)
Less state fiddling.
3 years, 9 months ago (2017-03-16 15:05:46 UTC) #3
fs
lgtm
3 years, 9 months ago (2017-03-16 15:15:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754783003/1
3 years, 9 months ago (2017-03-16 15:17:59 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 17:26:39 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b857e84f42f1571295105ce45346...

Powered by Google App Engine
This is Rietveld 408576698