Rename WebsiteSettings code to PageInfo.

Rename WebsiteSettings code to PageInfo.

This was automated using a script [1] that does the following:
- Rename relevant files in the following folders from website_settings* to
  page_info*:
  - chrome/browser/ui/page_info
  - chrome/browser/ui/cocoa/page_info
  - chrome/browser/ui/views/page_info
  - chrome/browser/ui/android/page_info
  - chrome/android/java/res/layout
- Run `./tools/git/mass-rename.py` to update e.g. includes, build files, header
  guards.
  - mass-rename.py does not handle test files (https://crbug.com/701529) or
    Java, so those are handled separately, either in an early step are as part
    of the later renames.
  - `page_info_bubble_controller.h` needs a separate header guard fix.
- Use `sed` to rename classes, enums, non-UMA strings, and comments *WebsiteSettings* to *PageInfo* across the entire Chromium project.
  - Since several content settings classes are also called "WebsiteSettings", this is done by taking a full list of all occurrences of full tokens containing "WebsiteSettings", "website_settings", or "website settings" and whitelisting individual replacements.
  - To avoid modifying strings, all lines containing the relevant tokens *following at least one quote mark on the same line* are preserved, except two individually handled cases. There do not appear to be any affected multi-line strings.
- `git cl format`
- Remove two long-standing TODO comments about this rename, in:
  - PageInfoPopup.java
  - page_info_bubble_controller.h

This CL does not attempt to reflow comments; all changes stay within 80 lines, though.

[1] https://github.com/lgarron/website-settings-to-page-info/blob/master/page_info.fish

BUG=571506
TBR=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2754383004
Cr-Commit-Position: refs/heads/master@{#459562}
Committed: https://chromium.googlesource.com/chromium/src/+/617a30f35e5cec5df6c15a8d7fbb222cdbabcccc

[lgarron, 2017-03-17 21:47:15]

Description was changed from

==========
Rename desktop WebsiteSettings*  classes to PageInfo*.

This was automated using a script [1] that does the following:
- Rename files in the 3 desktop page_info folders from website_settings to
  page_info. [2]
- Run `./tools/git/mass-rename.py` to update e.g. includes, build files, header
  guards. [3]
- Rename class names in the page_info folders from *WebsiteSettings* to
  *PageInfo* across the project (taking care not to rename histogram strings).

[1]
https://github.com/lgarron/website-settings-to-page-info/blob/954edf2475c8e8a...
[2] Test files must be separately renamed in `chrome/test/BUILD.gn`.
  (https://crbug.com/701529)
[3] `page_info_bubble_controller.h` needs a separate header guard fix.

BUG=571506
==========

to

==========
Rename desktop WebsiteSettings*  classes to PageInfo*.

This was automated using a script [1] that does the following:
- Rename files in the 3 desktop page_info folders from website_settings to
  page_info. [2]
- Run `./tools/git/mass-rename.py` to update e.g. includes, build files, header
  guards. [3]
- Rename class names in the page_info folders from *WebsiteSettings* to
  *PageInfo* across the project (taking care not to rename histogram strings).
- `git cl format`

[1]
https://github.com/lgarron/website-settings-to-page-info/blob/89eecdfae1a6ae6...
[2] Test files must be separately renamed in `chrome/test/BUILD.gn`.
  (https://crbug.com/701529)
[3] `page_info_bubble_controller.h` needs a separate header guard fix.

BUG=571506
==========

[lgarron, 2017-03-17 21:47:39]

lgarron@chromium.org changed reviewers:
+ estark@chromium.org

[lgarron, 2017-03-17 21:47:40]

estark@, could you review?

[lgarron, 2017-03-17 22:04:06]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 22:05:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 22:29:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 22:29:46]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[lgarron, 2017-03-18 00:37:26]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-18 00:38:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-18 01:07:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-18 01:07:04]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[estark, 2017-03-20 20:19:19]

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/android/p...
File chrome/browser/ui/android/page_info/connection_info_popup_android.h
(right):

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/android/p...
chrome/browser/ui/android/page_info/connection_info_popup_android.h:46: // The
presenter that controls the Website Settings UI.
Website Settings => Page Info
(maybe run a `git grep -i "website settings"`?)

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/android/p...
File chrome/browser/ui/android/page_info/website_settings_popup_android.h
(right):

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/android/p...
chrome/browser/ui/android/page_info/website_settings_popup_android.h:33: //
Android implementation of the website settings UI.
ditto

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/android/p...
chrome/browser/ui/android/page_info/website_settings_popup_android.h:34: class
WebsiteSettingsPopupAndroid : public PageInfoUI {
Shouldn't this be renamed to PageInfoPopupAndroid?

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/cocoa/pag...
File chrome/browser/ui/cocoa/page_info/page_info_bubble_controller_unittest.mm
(right):

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/cocoa/pag...
chrome/browser/ui/cocoa/page_info/page_info_bubble_controller_unittest.mm:37:
@interface WebsiteSettingsBubbleControllerForTesting
PageInfoBubbleControllerForTesting?

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/page_info...
File chrome/browser/ui/page_info/page_info.cc (right):

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/page_info...
chrome/browser/ui/page_info/page_info.cc:236: // Every time the Website Settings
UI is opened a |PageInfo| object is
Website Settings => Page Info

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/page_info...
chrome/browser/ui/page_info/page_info.cc:237: // created. So this counts how
ofter the Website Settings UI is opened.
ditto

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/page_info...
File chrome/browser/ui/page_info/page_info_ui.h (right):

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/page_info...
chrome/browser/ui/page_info/page_info_ui.h:30: // interface of the website
settings UI. The website settings UI displays
ditto

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/page_info...
chrome/browser/ui/page_info/page_info_ui.h:37: // The Website Settings UI
contains several tabs. Each tab is associated with
This comment needs to be updated, but the enum is also dead, it looks like.

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/page_info...
File chrome/browser/ui/page_info/page_info_unittest.cc (right):

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/page_info...
chrome/browser/ui/page_info/page_info_unittest.cc:122:
ASSERT_TRUE(website_settings_.get()) << "No PageInfo instance created.";
do |website_settings_| and its getter need to be renamed as well?

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/views/fra...
File chrome/browser/ui/views/frame/browser_view.cc (right):

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/browser_view.cc:1287: void
BrowserView::ShowWebsiteSettings(
ShowWebsiteSettings => ShowPageInfo?

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/views/pag...
File
chrome/browser/ui/views/page_info/page_info_popup_view_interactive_uitest.cc
(right):

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/views/pag...
chrome/browser/ui/views/page_info/page_info_popup_view_interactive_uitest.cc:34:
IN_PROC_BROWSER_TEST_F(WebSiteSettingsPopupViewBrowserTest, ShowPopup) {
I think test fixtures should be renamed as well; it's common for people to run
tests for the class named Blah with --gtest_filter="*Blah*".

[lgarron, 2017-03-20 23:09:03]

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/android/p...
File chrome/browser/ui/android/page_info/connection_info_popup_android.h
(right):

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/android/p...
chrome/browser/ui/android/page_info/connection_info_popup_android.h:46: // The
presenter that controls the Website Settings UI.
On 2017/03/20 at 20:19:17, estark wrote:
> Website Settings => Page Info
> (maybe run a `git grep -i "website settings"`?)

Well, isn't that lovely. Will do a search.

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/android/p...
File chrome/browser/ui/android/page_info/website_settings_popup_android.h
(right):

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/android/p...
chrome/browser/ui/android/page_info/website_settings_popup_android.h:34: class
WebsiteSettingsPopupAndroid : public PageInfoUI {
On 2017/03/20 at 20:19:17, estark wrote:
> Shouldn't this be renamed to PageInfoPopupAndroid?

I wanted to avoid doing Android in this CL, but it looks like that will be
awkward. I started down the path of including Android last Friday, but still
some to go.

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/cocoa/pag...
File chrome/browser/ui/cocoa/page_info/page_info_bubble_controller_unittest.mm
(right):

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/cocoa/pag...
chrome/browser/ui/cocoa/page_info/page_info_bubble_controller_unittest.mm:37:
@interface WebsiteSettingsBubbleControllerForTesting
On 2017/03/20 at 20:19:17, estark wrote:
> PageInfoBubbleControllerForTesting?

Seems my search didn't include Objective-C++ files as CPP. Thanks for catching!

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/views/fra...
File chrome/browser/ui/views/frame/browser_view.cc (right):

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/browser_view.cc:1287: void
BrowserView::ShowWebsiteSettings(
On 2017/03/20 at 20:19:17, estark wrote:
> ShowWebsiteSettings => ShowPageInfo?

Hmm, I wanted to avoid renaming any classes or methods outside of PageInfo in
the first CL, but I guess that doesn't seem to be working out. Will add this.

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/views/pag...
File
chrome/browser/ui/views/page_info/page_info_popup_view_interactive_uitest.cc
(right):

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/views/pag...
chrome/browser/ui/views/page_info/page_info_popup_view_interactive_uitest.cc:34:
IN_PROC_BROWSER_TEST_F(WebSiteSettingsPopupViewBrowserTest, ShowPopup) {
On 2017/03/20 at 20:19:17, estark wrote:
> I think test fixtures should be renamed as well; it's common for people to run
tests for the class named Blah with --gtest_filter="*Blah*".

Okay, will do a pass for those.

[lgarron, 2017-03-24 04:33:40]

Description was changed from

==========
Rename desktop WebsiteSettings*  classes to PageInfo*.

This was automated using a script [1] that does the following:
- Rename files in the 3 desktop page_info folders from website_settings to
  page_info. [2]
- Run `./tools/git/mass-rename.py` to update e.g. includes, build files, header
  guards. [3]
- Rename class names in the page_info folders from *WebsiteSettings* to
  *PageInfo* across the project (taking care not to rename histogram strings).
- `git cl format`

[1]
https://github.com/lgarron/website-settings-to-page-info/blob/89eecdfae1a6ae6...
[2] Test files must be separately renamed in `chrome/test/BUILD.gn`.
  (https://crbug.com/701529)
[3] `page_info_bubble_controller.h` needs a separate header guard fix.

BUG=571506
==========

to

==========
Rename desktop WebsiteSettings*  classes to PageInfo*.

This was automated using a script [1] that does the following:
- Rename relevant files in the following folders from website_settings* to
  page_info*:
  - chrome/browser/ui/page_info
  - chrome/browser/ui/cocoa/page_info
  - chrome/browser/ui/views/page_info
  - chrome/browser/ui/android/page_info
  - chrome/android/java/res/layout
- Run `./tools/git/mass-rename.py` to update e.g. includes, build files, header
  guards.
  - mass-rename.py does not handle test files (https://crbug.com/701529) or
    Java, so those are handled separately, either in an early step are as part
    of the later renames.
  - `page_info_bubble_controller.h` needs a separate header guard fix.
- Use `sed` to rename classes, enums, non-UMA strings, and comments
*WebsiteSettings* to *PageInfo* across the entire Chromium project.
  - Since several content settings classes are also called "WebsiteSettings",
this is done by taking a full list of all occurrences of full tokens including
"WebsiteSettings", "website_settings", and "website settings" and whitelisting
replacements.
  - All files containing strings are preserved, except two individually handled
cases.
- `git cl format`
- Remove two long-standing TODO comments about this rename (manual step).

[1]
https://github.com/lgarron/website-settings-to-page-info/blob/master/page_inf...

BUG=571506
==========

[lgarron, 2017-03-24 05:00:10]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 05:00:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lgarron, 2017-03-24 05:02:05]

Description was changed from

==========
Rename desktop WebsiteSettings*  classes to PageInfo*.

This was automated using a script [1] that does the following:
- Rename relevant files in the following folders from website_settings* to
  page_info*:
  - chrome/browser/ui/page_info
  - chrome/browser/ui/cocoa/page_info
  - chrome/browser/ui/views/page_info
  - chrome/browser/ui/android/page_info
  - chrome/android/java/res/layout
- Run `./tools/git/mass-rename.py` to update e.g. includes, build files, header
  guards.
  - mass-rename.py does not handle test files (https://crbug.com/701529) or
    Java, so those are handled separately, either in an early step are as part
    of the later renames.
  - `page_info_bubble_controller.h` needs a separate header guard fix.
- Use `sed` to rename classes, enums, non-UMA strings, and comments
*WebsiteSettings* to *PageInfo* across the entire Chromium project.
  - Since several content settings classes are also called "WebsiteSettings",
this is done by taking a full list of all occurrences of full tokens including
"WebsiteSettings", "website_settings", and "website settings" and whitelisting
replacements.
  - All files containing strings are preserved, except two individually handled
cases.
- `git cl format`
- Remove two long-standing TODO comments about this rename (manual step).

[1]
https://github.com/lgarron/website-settings-to-page-info/blob/master/page_inf...

BUG=571506
==========

to

==========
Rename WebsiteSettings code to PageInfo.

This was automated using a script [1] that does the following:
- Rename relevant files in the following folders from website_settings* to
  page_info*:
  - chrome/browser/ui/page_info
  - chrome/browser/ui/cocoa/page_info
  - chrome/browser/ui/views/page_info
  - chrome/browser/ui/android/page_info
  - chrome/android/java/res/layout
- Run `./tools/git/mass-rename.py` to update e.g. includes, build files, header
  guards.
  - mass-rename.py does not handle test files (https://crbug.com/701529) or
    Java, so those are handled separately, either in an early step are as part
    of the later renames.
  - `page_info_bubble_controller.h` needs a separate header guard fix.
- Use `sed` to rename classes, enums, non-UMA strings, and comments
*WebsiteSettings* to *PageInfo* across the entire Chromium project.
  - Since several content settings classes are also called "WebsiteSettings",
this is done by taking a full list of all occurrences of full tokens including
"WebsiteSettings", "website_settings", and "website settings" and whitelisting
replacements.
  - All files containing strings are preserved, except two individually handled
cases.
- `git cl format`
- Remove two long-standing TODO comments about this rename (manual step).

[1]
https://github.com/lgarron/website-settings-to-page-info/blob/master/page_inf...

BUG=571506
==========

[lgarron, 2017-03-24 05:55:19]

lgarron@chromium.org changed reviewers:
+ isherman@chromium.org, msw@chromium.org, rsesek@chromium.org,
tedchoc@chromium.org

[lgarron, 2017-03-24 05:55:20]

estark@, could you review again (whole thing)?
tedchoc@, could you review the Java code?
msw@, could you review Views?
rsesek@, could you review Cocoa?
isherman@, could you review  tools/metrics and do a quick pass over the rest? I
was careful not to rename any UMA histograms/actions, but it's possible I may
have errors.

jochen@: There are references to update in some misc. files. You're welcome to
review, else I plan to TBR you for the small changes in:
  - build/android/pylib/gtest/filter/unit_tests_disabled
  - chrome/browser/chromeos/login/ui/simple_web_view_dialog.* (2 files)
  - chrome/test/base/test_browser_window.h
  - components/infobars/core/infobar_delegate.h
  - ios/chrome/browser/ui/dialogs/nsurl_protection_space_util*.mm (2 files)

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/page_info...
File chrome/browser/ui/page_info/page_info_unittest.cc (right):

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/page_info...
chrome/browser/ui/page_info/page_info_unittest.cc:122:
ASSERT_TRUE(website_settings_.get()) << "No PageInfo instance created.";
On 2017/03/20 at 20:19:17, estark wrote:
> do |website_settings_| and its getter need to be renamed as well?

Done in the latest patch.

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/views/pag...
File
chrome/browser/ui/views/page_info/page_info_popup_view_interactive_uitest.cc
(right):

https://codereview.chromium.org/2754383004/diff/1/chrome/browser/ui/views/pag...
chrome/browser/ui/views/page_info/page_info_popup_view_interactive_uitest.cc:34:
IN_PROC_BROWSER_TEST_F(WebSiteSettingsPopupViewBrowserTest, ShowPopup) {
On 2017/03/20 at 23:09:03, lgarron wrote:
> On 2017/03/20 at 20:19:17, estark wrote:
> > I think test fixtures should be renamed as well; it's common for people to
run tests for the class named Blah with --gtest_filter="*Blah*".
> 
> Okay, will do a pass for those.

Turns out the reason I missed this is because
WebSiteSettingsPopupViewBrowserTest is the only instance that capitalizes
"WebsiteSettings" as "WebSiteSettings". I've done a case-sensitive search to
confirm there are no others.

[lgarron, 2017-03-24 05:59:52]

Description was changed from

==========
Rename WebsiteSettings code to PageInfo.

This was automated using a script [1] that does the following:
- Rename relevant files in the following folders from website_settings* to
  page_info*:
  - chrome/browser/ui/page_info
  - chrome/browser/ui/cocoa/page_info
  - chrome/browser/ui/views/page_info
  - chrome/browser/ui/android/page_info
  - chrome/android/java/res/layout
- Run `./tools/git/mass-rename.py` to update e.g. includes, build files, header
  guards.
  - mass-rename.py does not handle test files (https://crbug.com/701529) or
    Java, so those are handled separately, either in an early step are as part
    of the later renames.
  - `page_info_bubble_controller.h` needs a separate header guard fix.
- Use `sed` to rename classes, enums, non-UMA strings, and comments
*WebsiteSettings* to *PageInfo* across the entire Chromium project.
  - Since several content settings classes are also called "WebsiteSettings",
this is done by taking a full list of all occurrences of full tokens including
"WebsiteSettings", "website_settings", and "website settings" and whitelisting
replacements.
  - All files containing strings are preserved, except two individually handled
cases.
- `git cl format`
- Remove two long-standing TODO comments about this rename (manual step).

[1]
https://github.com/lgarron/website-settings-to-page-info/blob/master/page_inf...

BUG=571506
==========

to

==========
Rename WebsiteSettings code to PageInfo.

This was automated using a script [1] that does the following:
- Rename relevant files in the following folders from website_settings* to
  page_info*:
  - chrome/browser/ui/page_info
  - chrome/browser/ui/cocoa/page_info
  - chrome/browser/ui/views/page_info
  - chrome/browser/ui/android/page_info
  - chrome/android/java/res/layout
- Run `./tools/git/mass-rename.py` to update e.g. includes, build files, header
  guards.
  - mass-rename.py does not handle test files (https://crbug.com/701529) or
    Java, so those are handled separately, either in an early step are as part
    of the later renames.
  - `page_info_bubble_controller.h` needs a separate header guard fix.
- Use `sed` to rename classes, enums, non-UMA strings, and comments
*WebsiteSettings* to *PageInfo* across the entire Chromium project.
  - Since several content settings classes are also called "WebsiteSettings",
this is done by taking a full list of all occurrences of full tokens containing
"WebsiteSettings", "website_settings", or "website settings" and whitelisting
individual replacements.
  - To avoid modifying strings, all lines containing the relevant tokens after
at least one quote mark are preserved, except two individually handled cases.
- `git cl format`
- Remove two long-standing TODO comments about this rename (manual step), in:
  - PageInfoPopup.java
  - page_info_bubble_controller.h

[1]
https://github.com/lgarron/website-settings-to-page-info/blob/master/page_inf...

BUG=571506
==========

[lgarron, 2017-03-24 06:02:09]

Description was changed from

==========
Rename WebsiteSettings code to PageInfo.

This was automated using a script [1] that does the following:
- Rename relevant files in the following folders from website_settings* to
  page_info*:
  - chrome/browser/ui/page_info
  - chrome/browser/ui/cocoa/page_info
  - chrome/browser/ui/views/page_info
  - chrome/browser/ui/android/page_info
  - chrome/android/java/res/layout
- Run `./tools/git/mass-rename.py` to update e.g. includes, build files, header
  guards.
  - mass-rename.py does not handle test files (https://crbug.com/701529) or
    Java, so those are handled separately, either in an early step are as part
    of the later renames.
  - `page_info_bubble_controller.h` needs a separate header guard fix.
- Use `sed` to rename classes, enums, non-UMA strings, and comments
*WebsiteSettings* to *PageInfo* across the entire Chromium project.
  - Since several content settings classes are also called "WebsiteSettings",
this is done by taking a full list of all occurrences of full tokens containing
"WebsiteSettings", "website_settings", or "website settings" and whitelisting
individual replacements.
  - To avoid modifying strings, all lines containing the relevant tokens after
at least one quote mark are preserved, except two individually handled cases.
- `git cl format`
- Remove two long-standing TODO comments about this rename (manual step), in:
  - PageInfoPopup.java
  - page_info_bubble_controller.h

[1]
https://github.com/lgarron/website-settings-to-page-info/blob/master/page_inf...

BUG=571506
==========

to

==========
Rename WebsiteSettings code to PageInfo.

This was automated using a script [1] that does the following:
- Rename relevant files in the following folders from website_settings* to
  page_info*:
  - chrome/browser/ui/page_info
  - chrome/browser/ui/cocoa/page_info
  - chrome/browser/ui/views/page_info
  - chrome/browser/ui/android/page_info
  - chrome/android/java/res/layout
- Run `./tools/git/mass-rename.py` to update e.g. includes, build files, header
  guards.
  - mass-rename.py does not handle test files (https://crbug.com/701529) or
    Java, so those are handled separately, either in an early step are as part
    of the later renames.
  - `page_info_bubble_controller.h` needs a separate header guard fix.
- Use `sed` to rename classes, enums, non-UMA strings, and comments
*WebsiteSettings* to *PageInfo* across the entire Chromium project.
  - Since several content settings classes are also called "WebsiteSettings",
this is done by taking a full list of all occurrences of full tokens containing
"WebsiteSettings", "website_settings", or "website settings" and whitelisting
individual replacements.
  - To avoid modifying strings, all lines containing the relevant tokens after
at least one quote mark are preserved, except two individually handled cases.
- `git cl format`
- Remove two long-standing TODO comments about this rename (manual step), in:
  - PageInfoPopup.java
  - page_info_bubble_controller.h

This CL does not attempt to reflow comments; all changes stay within 80 lines,
though.

[1]
https://github.com/lgarron/website-settings-to-page-info/blob/master/page_inf...

BUG=571506
==========

[commit-bot: I haz the power, 2017-03-24 06:43:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 06:43:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2017-03-24 16:25:01]

I went over everything, maybe that alleviates other c/b/ui/*/OWNERS?
lgtm with a minor "is not supported" comment fix and (optional) nits.

https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/brows...
File chrome/browser/ui/browser_window.h (right):

https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/brows...
chrome/browser/ui/browser_window.h:296: // Shows the website settings using the
specified information. |virtual_url|
nit: update

https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h (right):

https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h:113: // Provides
a bridge between the WebSettingsUI C++ interface and the Cocoa
nit: update

https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/page_...
File chrome/browser/ui/page_info/page_info_ui.h (right):

https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/page_...
chrome/browser/ui/page_info/page_info_ui.h:29: // The class |PageInfoUI|
specifies the platform independent
optional nit: reflow comment

https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/page_...
File chrome/browser/ui/page_info/page_info_unittest.cc (right):

https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/page_...
chrome/browser/ui/page_info/page_info_unittest.cc:151: const
std::vector<std::unique_ptr<PageInfoUI::ChosenObjectInfo>>&
optional nit: use ChosenObjectInfoList here and on line 183

https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/page_...
chrome/browser/ui/page_info/page_info_unittest.cc:701: // RecordPageInfoAction()
is called during PageInfo
optional nit: reflow comment

https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/browser_dialogs_views_mac.cc (right):

https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/browser_dialogs_views_mac.cc:37: if
(PageInfoPopupView::GetShownPopupType() != PageInfoPopupView::POPUP_NONE) {
nit: remove curlies

https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/page_info/page_info_popup_view.cc (right):

https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/page_info/page_info_popup_view.cc:162: // The regular
PageInfoPopupView supported for internal Chrome pages and
This should say "is not supported".

https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/page_info/permission_selector_row.cc (right):

https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/page_info/permission_selector_row.cc:334: // Re-layout
will be done at the |PageInfoPopupView| level, since
optional nit: reflow comment

[lgarron, 2017-03-24 18:30:46]

Description was changed from

==========
Rename WebsiteSettings code to PageInfo.

This was automated using a script [1] that does the following:
- Rename relevant files in the following folders from website_settings* to
  page_info*:
  - chrome/browser/ui/page_info
  - chrome/browser/ui/cocoa/page_info
  - chrome/browser/ui/views/page_info
  - chrome/browser/ui/android/page_info
  - chrome/android/java/res/layout
- Run `./tools/git/mass-rename.py` to update e.g. includes, build files, header
  guards.
  - mass-rename.py does not handle test files (https://crbug.com/701529) or
    Java, so those are handled separately, either in an early step are as part
    of the later renames.
  - `page_info_bubble_controller.h` needs a separate header guard fix.
- Use `sed` to rename classes, enums, non-UMA strings, and comments
*WebsiteSettings* to *PageInfo* across the entire Chromium project.
  - Since several content settings classes are also called "WebsiteSettings",
this is done by taking a full list of all occurrences of full tokens containing
"WebsiteSettings", "website_settings", or "website settings" and whitelisting
individual replacements.
  - To avoid modifying strings, all lines containing the relevant tokens after
at least one quote mark are preserved, except two individually handled cases.
- `git cl format`
- Remove two long-standing TODO comments about this rename (manual step), in:
  - PageInfoPopup.java
  - page_info_bubble_controller.h

This CL does not attempt to reflow comments; all changes stay within 80 lines,
though.

[1]
https://github.com/lgarron/website-settings-to-page-info/blob/master/page_inf...

BUG=571506
==========

to

==========
Rename WebsiteSettings code to PageInfo.

This was automated using a script [1] that does the following:
- Rename relevant files in the following folders from website_settings* to
  page_info*:
  - chrome/browser/ui/page_info
  - chrome/browser/ui/cocoa/page_info
  - chrome/browser/ui/views/page_info
  - chrome/browser/ui/android/page_info
  - chrome/android/java/res/layout
- Run `./tools/git/mass-rename.py` to update e.g. includes, build files, header
  guards.
  - mass-rename.py does not handle test files (https://crbug.com/701529) or
    Java, so those are handled separately, either in an early step are as part
    of the later renames.
  - `page_info_bubble_controller.h` needs a separate header guard fix.
- Use `sed` to rename classes, enums, non-UMA strings, and comments
*WebsiteSettings* to *PageInfo* across the entire Chromium project.
  - Since several content settings classes are also called "WebsiteSettings",
this is done by taking a full list of all occurrences of full tokens containing
"WebsiteSettings", "website_settings", or "website settings" and whitelisting
individual replacements.
  - To avoid modifying strings, all lines containing the relevant tokens after
at least one quote mark are preserved, except two individually handled cases.
- `git cl format`
- Remove two long-standing TODO comments about this rename, in:
  - PageInfoPopup.java
  - page_info_bubble_controller.h

This CL does not attempt to reflow comments; all changes stay within 80 lines,
though.

[1]
https://github.com/lgarron/website-settings-to-page-info/blob/master/page_inf...

BUG=571506
==========

[Ted C, 2017-03-24 18:34:07]

On 2017/03/24 16:25:01, msw wrote:
> I went over everything, maybe that alleviates other c/b/ui/*/OWNERS?
> lgtm with a minor "is not supported" comment fix and (optional) nits.
> 
>
https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/brows...
> File chrome/browser/ui/browser_window.h (right):
> 
>
https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/brows...
> chrome/browser/ui/browser_window.h:296: // Shows the website settings using
the
> specified information. |virtual_url|
> nit: update
> 
>
https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/cocoa...
> File chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h (right):
> 
>
https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/cocoa...
> chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h:113: //
Provides
> a bridge between the WebSettingsUI C++ interface and the Cocoa
> nit: update
> 
>
https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/page_...
> File chrome/browser/ui/page_info/page_info_ui.h (right):
> 
>
https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/page_...
> chrome/browser/ui/page_info/page_info_ui.h:29: // The class |PageInfoUI|
> specifies the platform independent
> optional nit: reflow comment
> 
>
https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/page_...
> File chrome/browser/ui/page_info/page_info_unittest.cc (right):
> 
>
https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/page_...
> chrome/browser/ui/page_info/page_info_unittest.cc:151: const
> std::vector<std::unique_ptr<PageInfoUI::ChosenObjectInfo>>&
> optional nit: use ChosenObjectInfoList here and on line 183
> 
>
https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/page_...
> chrome/browser/ui/page_info/page_info_unittest.cc:701: //
RecordPageInfoAction()
> is called during PageInfo
> optional nit: reflow comment
> 
>
https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/views...
> File chrome/browser/ui/views/browser_dialogs_views_mac.cc (right):
> 
>
https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/views...
> chrome/browser/ui/views/browser_dialogs_views_mac.cc:37: if
> (PageInfoPopupView::GetShownPopupType() != PageInfoPopupView::POPUP_NONE) {
> nit: remove curlies
> 
>
https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/views...
> File chrome/browser/ui/views/page_info/page_info_popup_view.cc (right):
> 
>
https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/views...
> chrome/browser/ui/views/page_info/page_info_popup_view.cc:162: // The regular
> PageInfoPopupView supported for internal Chrome pages and
> This should say "is not supported".
> 
>
https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/views...
> File chrome/browser/ui/views/page_info/permission_selector_row.cc (right):
> 
>
https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/views...
> chrome/browser/ui/views/page_info/permission_selector_row.cc:334: // Re-layout
> will be done at the |PageInfoPopupView| level, since
> optional nit: reflow comment

android lgtm

[lgarron, 2017-03-24 18:39:54]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[lgarron, 2017-03-24 18:40:19]

https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/brows...
File chrome/browser/ui/browser_window.h (right):

https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/brows...
chrome/browser/ui/browser_window.h:296: // Shows the website settings using the
specified information. |virtual_url|
On 2017/03/24 at 16:25:00, msw wrote:
> nit: update

Done.

https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h (right):

https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h:113: // Provides
a bridge between the WebSettingsUI C++ interface and the Cocoa
On 2017/03/24 at 16:25:00, msw wrote:
> nit: update

What a typo! Done.

https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/page_...
File chrome/browser/ui/page_info/page_info_ui.h (right):

https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/page_...
chrome/browser/ui/page_info/page_info_ui.h:29: // The class |PageInfoUI|
specifies the platform independent
On 2017/03/24 at 16:25:00, msw wrote:
> optional nit: reflow comment

I want to avoid anything that can't be automated, but I've filed a follow-up
bug: https://bugs.chromium.org/p/chromium/issues/detail?id=704996

https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/browser_dialogs_views_mac.cc (right):

https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/browser_dialogs_views_mac.cc:37: if
(PageInfoPopupView::GetShownPopupType() != PageInfoPopupView::POPUP_NONE) {
On 2017/03/24 at 16:25:00, msw wrote:
> nit: remove curlies

I want to avoid changing the structure of the code, and this would require a bit
more magic to automate.
I also have a bug about making braces across single lines consistent in Page
Info later on.

https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/page_info/page_info_popup_view.cc (right):

https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/page_info/page_info_popup_view.cc:162: // The regular
PageInfoPopupView supported for internal Chrome pages and
On 2017/03/24 at 16:25:00, msw wrote:
> This should say "is not supported".

Thanks, good catch. I've fixed the replacement using with matching subject-verb
agreement.

https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/page_info/permission_selector_row.cc (right):

https://codereview.chromium.org/2754383004/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/page_info/permission_selector_row.cc:334: // Re-layout
will be done at the |PageInfoPopupView| level, since
On 2017/03/24 at 16:25:00, msw wrote:
> optional nit: reflow comment

(As above: to be handled in
https://bugs.chromium.org/p/chromium/issues/detail?id=704996)

[commit-bot: I haz the power, 2017-03-24 18:40:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lgarron, 2017-03-24 18:42:37]

Description was changed from

==========
Rename WebsiteSettings code to PageInfo.

This was automated using a script [1] that does the following:
- Rename relevant files in the following folders from website_settings* to
  page_info*:
  - chrome/browser/ui/page_info
  - chrome/browser/ui/cocoa/page_info
  - chrome/browser/ui/views/page_info
  - chrome/browser/ui/android/page_info
  - chrome/android/java/res/layout
- Run `./tools/git/mass-rename.py` to update e.g. includes, build files, header
  guards.
  - mass-rename.py does not handle test files (https://crbug.com/701529) or
    Java, so those are handled separately, either in an early step are as part
    of the later renames.
  - `page_info_bubble_controller.h` needs a separate header guard fix.
- Use `sed` to rename classes, enums, non-UMA strings, and comments
*WebsiteSettings* to *PageInfo* across the entire Chromium project.
  - Since several content settings classes are also called "WebsiteSettings",
this is done by taking a full list of all occurrences of full tokens containing
"WebsiteSettings", "website_settings", or "website settings" and whitelisting
individual replacements.
  - To avoid modifying strings, all lines containing the relevant tokens after
at least one quote mark are preserved, except two individually handled cases.
- `git cl format`
- Remove two long-standing TODO comments about this rename, in:
  - PageInfoPopup.java
  - page_info_bubble_controller.h

This CL does not attempt to reflow comments; all changes stay within 80 lines,
though.

[1]
https://github.com/lgarron/website-settings-to-page-info/blob/master/page_inf...

BUG=571506
==========

to

==========
Rename WebsiteSettings code to PageInfo.

This was automated using a script [1] that does the following:
- Rename relevant files in the following folders from website_settings* to
  page_info*:
  - chrome/browser/ui/page_info
  - chrome/browser/ui/cocoa/page_info
  - chrome/browser/ui/views/page_info
  - chrome/browser/ui/android/page_info
  - chrome/android/java/res/layout
- Run `./tools/git/mass-rename.py` to update e.g. includes, build files, header
  guards.
  - mass-rename.py does not handle test files (https://crbug.com/701529) or
    Java, so those are handled separately, either in an early step are as part
    of the later renames.
  - `page_info_bubble_controller.h` needs a separate header guard fix.
- Use `sed` to rename classes, enums, non-UMA strings, and comments
*WebsiteSettings* to *PageInfo* across the entire Chromium project.
  - Since several content settings classes are also called "WebsiteSettings",
this is done by taking a full list of all occurrences of full tokens containing
"WebsiteSettings", "website_settings", or "website settings" and whitelisting
individual replacements.
  - To avoid modifying strings, all lines containing the relevant tokens
*following at least one quote mark* are preserved, except two individually
handled cases.
- `git cl format`
- Remove two long-standing TODO comments about this rename, in:
  - PageInfoPopup.java
  - page_info_bubble_controller.h

This CL does not attempt to reflow comments; all changes stay within 80 lines,
though.

[1]
https://github.com/lgarron/website-settings-to-page-info/blob/master/page_inf...

BUG=571506
==========

[lgarron, 2017-03-24 18:43:09]

Description was changed from

==========
Rename WebsiteSettings code to PageInfo.

This was automated using a script [1] that does the following:
- Rename relevant files in the following folders from website_settings* to
  page_info*:
  - chrome/browser/ui/page_info
  - chrome/browser/ui/cocoa/page_info
  - chrome/browser/ui/views/page_info
  - chrome/browser/ui/android/page_info
  - chrome/android/java/res/layout
- Run `./tools/git/mass-rename.py` to update e.g. includes, build files, header
  guards.
  - mass-rename.py does not handle test files (https://crbug.com/701529) or
    Java, so those are handled separately, either in an early step are as part
    of the later renames.
  - `page_info_bubble_controller.h` needs a separate header guard fix.
- Use `sed` to rename classes, enums, non-UMA strings, and comments
*WebsiteSettings* to *PageInfo* across the entire Chromium project.
  - Since several content settings classes are also called "WebsiteSettings",
this is done by taking a full list of all occurrences of full tokens containing
"WebsiteSettings", "website_settings", or "website settings" and whitelisting
individual replacements.
  - To avoid modifying strings, all lines containing the relevant tokens
*following at least one quote mark* are preserved, except two individually
handled cases.
- `git cl format`
- Remove two long-standing TODO comments about this rename, in:
  - PageInfoPopup.java
  - page_info_bubble_controller.h

This CL does not attempt to reflow comments; all changes stay within 80 lines,
though.

[1]
https://github.com/lgarron/website-settings-to-page-info/blob/master/page_inf...

BUG=571506
==========

to

==========
Rename WebsiteSettings code to PageInfo.

This was automated using a script [1] that does the following:
- Rename relevant files in the following folders from website_settings* to
  page_info*:
  - chrome/browser/ui/page_info
  - chrome/browser/ui/cocoa/page_info
  - chrome/browser/ui/views/page_info
  - chrome/browser/ui/android/page_info
  - chrome/android/java/res/layout
- Run `./tools/git/mass-rename.py` to update e.g. includes, build files, header
  guards.
  - mass-rename.py does not handle test files (https://crbug.com/701529) or
    Java, so those are handled separately, either in an early step are as part
    of the later renames.
  - `page_info_bubble_controller.h` needs a separate header guard fix.
- Use `sed` to rename classes, enums, non-UMA strings, and comments
*WebsiteSettings* to *PageInfo* across the entire Chromium project.
  - Since several content settings classes are also called "WebsiteSettings",
this is done by taking a full list of all occurrences of full tokens containing
"WebsiteSettings", "website_settings", or "website settings" and whitelisting
individual replacements.
  - To avoid modifying strings, all lines containing the relevant tokens
*following at least one quote mark on the same line* are preserved, except two
individually handled cases. There do not appear to be any affected multi-line
strings.
- `git cl format`
- Remove two long-standing TODO comments about this rename, in:
  - PageInfoPopup.java
  - page_info_bubble_controller.h

This CL does not attempt to reflow comments; all changes stay within 80 lines,
though.

[1]
https://github.com/lgarron/website-settings-to-page-info/blob/master/page_inf...

BUG=571506
==========

[msw, 2017-03-24 18:55:13]

still lgtm with a nit; please try to upload separate patch sets when rebasing
and addressing code review comments; it makes it easier for reviewers to compare
diffs.

https://codereview.chromium.org/2754383004/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h (right):

https://codereview.chromium.org/2754383004/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h:113: // Provides
a bridge between the WebSettingsUI C++ interface and the Cocoa
nit: still not fixed

[lgarron, 2017-03-24 18:55:54]

The CQ bit was checked by lgarron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 18:56:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lgarron, 2017-03-24 18:59:00]

Sorry, I accidentally pushed a revision without that fix; seems your comment
beat my fixed upload. ;-)

I generally have little patience for manual work that should be fixed by better
tooling, but I'll try to remember to rebase separately as much as I can.

[estark, 2017-03-24 19:20:07]

lgtm

[lgarron, 2017-03-24 19:26:21]

lgarron@chromium.org changed reviewers:
- rsesek@chromium.org

[lgarron, 2017-03-24 19:26:22]

Moving rsesek@ to optional reviewer, since msw@ covered chrome/browser/ui, and
the changes are mechanical (albeit many).

[Alexei Svitkine (slow), 2017-03-24 20:57:49]

asvitkine@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Alexei Svitkine (slow), 2017-03-24 20:57:51]

histograms.xml lgtm

[lgarron, 2017-03-24 20:58:48]

Description was changed from

==========
Rename WebsiteSettings code to PageInfo.

This was automated using a script [1] that does the following:
- Rename relevant files in the following folders from website_settings* to
  page_info*:
  - chrome/browser/ui/page_info
  - chrome/browser/ui/cocoa/page_info
  - chrome/browser/ui/views/page_info
  - chrome/browser/ui/android/page_info
  - chrome/android/java/res/layout
- Run `./tools/git/mass-rename.py` to update e.g. includes, build files, header
  guards.
  - mass-rename.py does not handle test files (https://crbug.com/701529) or
    Java, so those are handled separately, either in an early step are as part
    of the later renames.
  - `page_info_bubble_controller.h` needs a separate header guard fix.
- Use `sed` to rename classes, enums, non-UMA strings, and comments
*WebsiteSettings* to *PageInfo* across the entire Chromium project.
  - Since several content settings classes are also called "WebsiteSettings",
this is done by taking a full list of all occurrences of full tokens containing
"WebsiteSettings", "website_settings", or "website settings" and whitelisting
individual replacements.
  - To avoid modifying strings, all lines containing the relevant tokens
*following at least one quote mark on the same line* are preserved, except two
individually handled cases. There do not appear to be any affected multi-line
strings.
- `git cl format`
- Remove two long-standing TODO comments about this rename, in:
  - PageInfoPopup.java
  - page_info_bubble_controller.h

This CL does not attempt to reflow comments; all changes stay within 80 lines,
though.

[1]
https://github.com/lgarron/website-settings-to-page-info/blob/master/page_inf...

BUG=571506
==========

to

==========
Rename WebsiteSettings code to PageInfo.

This was automated using a script [1] that does the following:
- Rename relevant files in the following folders from website_settings* to
  page_info*:
  - chrome/browser/ui/page_info
  - chrome/browser/ui/cocoa/page_info
  - chrome/browser/ui/views/page_info
  - chrome/browser/ui/android/page_info
  - chrome/android/java/res/layout
- Run `./tools/git/mass-rename.py` to update e.g. includes, build files, header
  guards.
  - mass-rename.py does not handle test files (https://crbug.com/701529) or
    Java, so those are handled separately, either in an early step are as part
    of the later renames.
  - `page_info_bubble_controller.h` needs a separate header guard fix.
- Use `sed` to rename classes, enums, non-UMA strings, and comments
*WebsiteSettings* to *PageInfo* across the entire Chromium project.
  - Since several content settings classes are also called "WebsiteSettings",
this is done by taking a full list of all occurrences of full tokens containing
"WebsiteSettings", "website_settings", or "website settings" and whitelisting
individual replacements.
  - To avoid modifying strings, all lines containing the relevant tokens
*following at least one quote mark on the same line* are preserved, except two
individually handled cases. There do not appear to be any affected multi-line
strings.
- `git cl format`
- Remove two long-standing TODO comments about this rename, in:
  - PageInfoPopup.java
  - page_info_bubble_controller.h

This CL does not attempt to reflow comments; all changes stay within 80 lines,
though.

[1]
https://github.com/lgarron/website-settings-to-page-info/blob/master/page_inf...

BUG=571506
TBR=jochen@chromium.org
==========

[lgarron, 2017-03-24 20:58:48]

lgarron@chromium.org changed reviewers:
- isherman@chromium.org

[commit-bot: I haz the power, 2017-03-24 21:29:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 21:29:31]

Dry run: This issue passed the CQ dry run.

[lgarron, 2017-03-24 21:31:35]

The CQ bit was checked by lgarron@chromium.org

[lgarron, 2017-03-24 21:31:36]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2754383004/#ps60001
(title: "Upload missing comment fix for WebSettingsUI -> PageInfoUI.")

[commit-bot: I haz the power, 2017-03-24 21:32:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 21:42:14]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490391095993650,
"parent_rev": "9927414f3150565bbe283e1134a2cfb966a60b5e", "commit_rev":
"617a30f35e5cec5df6c15a8d7fbb222cdbabcccc"}

[commit-bot: I haz the power, 2017-03-24 21:44:08]

Description was changed from

==========
Rename WebsiteSettings code to PageInfo.

This was automated using a script [1] that does the following:
- Rename relevant files in the following folders from website_settings* to
  page_info*:
  - chrome/browser/ui/page_info
  - chrome/browser/ui/cocoa/page_info
  - chrome/browser/ui/views/page_info
  - chrome/browser/ui/android/page_info
  - chrome/android/java/res/layout
- Run `./tools/git/mass-rename.py` to update e.g. includes, build files, header
  guards.
  - mass-rename.py does not handle test files (https://crbug.com/701529) or
    Java, so those are handled separately, either in an early step are as part
    of the later renames.
  - `page_info_bubble_controller.h` needs a separate header guard fix.
- Use `sed` to rename classes, enums, non-UMA strings, and comments
*WebsiteSettings* to *PageInfo* across the entire Chromium project.
  - Since several content settings classes are also called "WebsiteSettings",
this is done by taking a full list of all occurrences of full tokens containing
"WebsiteSettings", "website_settings", or "website settings" and whitelisting
individual replacements.
  - To avoid modifying strings, all lines containing the relevant tokens
*following at least one quote mark on the same line* are preserved, except two
individually handled cases. There do not appear to be any affected multi-line
strings.
- `git cl format`
- Remove two long-standing TODO comments about this rename, in:
  - PageInfoPopup.java
  - page_info_bubble_controller.h

This CL does not attempt to reflow comments; all changes stay within 80 lines,
though.

[1]
https://github.com/lgarron/website-settings-to-page-info/blob/master/page_inf...

BUG=571506
TBR=jochen@chromium.org
==========

to

==========
Rename WebsiteSettings code to PageInfo.

This was automated using a script [1] that does the following:
- Rename relevant files in the following folders from website_settings* to
  page_info*:
  - chrome/browser/ui/page_info
  - chrome/browser/ui/cocoa/page_info
  - chrome/browser/ui/views/page_info
  - chrome/browser/ui/android/page_info
  - chrome/android/java/res/layout
- Run `./tools/git/mass-rename.py` to update e.g. includes, build files, header
  guards.
  - mass-rename.py does not handle test files (https://crbug.com/701529) or
    Java, so those are handled separately, either in an early step are as part
    of the later renames.
  - `page_info_bubble_controller.h` needs a separate header guard fix.
- Use `sed` to rename classes, enums, non-UMA strings, and comments
*WebsiteSettings* to *PageInfo* across the entire Chromium project.
  - Since several content settings classes are also called "WebsiteSettings",
this is done by taking a full list of all occurrences of full tokens containing
"WebsiteSettings", "website_settings", or "website settings" and whitelisting
individual replacements.
  - To avoid modifying strings, all lines containing the relevant tokens
*following at least one quote mark on the same line* are preserved, except two
individually handled cases. There do not appear to be any affected multi-line
strings.
- `git cl format`
- Remove two long-standing TODO comments about this rename, in:
  - PageInfoPopup.java
  - page_info_bubble_controller.h

This CL does not attempt to reflow comments; all changes stay within 80 lines,
though.

[1]
https://github.com/lgarron/website-settings-to-page-info/blob/master/page_inf...

BUG=571506
TBR=jochen@chromium.org

Review-Url: https://codereview.chromium.org/2754383004
Cr-Commit-Position: refs/heads/master@{#459562}
Committed:
https://chromium.googlesource.com/chromium/src/+/617a30f35e5cec5df6c15a8d7fbb...
==========

[commit-bot: I haz the power, 2017-03-24 21:44:10]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/617a30f35e5cec5df6c15a8d7fbb...

[Robert Sesek, 2017-03-29 16:00:58]

rsesek@chromium.org changed reviewers:
+ rsesek@chromium.org

[Robert Sesek, 2017-03-29 16:00:59]

lgtm