Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2661)

Unified Diff: chrome/browser/ui/views/page_info/page_info_popup_view_interactive_uitest.cc

Issue 2754383004: Rename WebsiteSettings code to PageInfo. (Closed)
Patch Set: Upload missing comment fix for WebSettingsUI -> PageInfoUI. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/page_info/page_info_popup_view_interactive_uitest.cc
diff --git a/chrome/browser/ui/views/page_info/website_settings_popup_view_interactive_uitest.cc b/chrome/browser/ui/views/page_info/page_info_popup_view_interactive_uitest.cc
similarity index 76%
rename from chrome/browser/ui/views/page_info/website_settings_popup_view_interactive_uitest.cc
rename to chrome/browser/ui/views/page_info/page_info_popup_view_interactive_uitest.cc
index 822c1c29d6feb7dc4e4f1a9eeebcf3b60837021e..d464caf8e02e9905645aa2d82467176627011e73 100644
--- a/chrome/browser/ui/views/page_info/website_settings_popup_view_interactive_uitest.cc
+++ b/chrome/browser/ui/views/page_info/page_info_popup_view_interactive_uitest.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/ui/views/page_info/website_settings_popup_view.h"
+#include "chrome/browser/ui/views/page_info/page_info_popup_view.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
@@ -33,15 +33,15 @@ void ClickAndWait(Browser* browser) {
IN_PROC_BROWSER_TEST_F(WebSiteSettingsPopupViewBrowserTest, ShowPopup) {
ClickAndWait(browser());
- EXPECT_EQ(WebsiteSettingsPopupView::POPUP_WEBSITE_SETTINGS,
- WebsiteSettingsPopupView::GetShownPopupType());
+ EXPECT_EQ(PageInfoPopupView::POPUP_PAGE_INFO,
+ PageInfoPopupView::GetShownPopupType());
}
IN_PROC_BROWSER_TEST_F(WebSiteSettingsPopupViewBrowserTest, ChromeURL) {
ui_test_utils::NavigateToURL(browser(), GURL("chrome://settings"));
ClickAndWait(browser());
- EXPECT_EQ(WebsiteSettingsPopupView::POPUP_INTERNAL_PAGE,
- WebsiteSettingsPopupView::GetShownPopupType());
+ EXPECT_EQ(PageInfoPopupView::POPUP_INTERNAL_PAGE,
+ PageInfoPopupView::GetShownPopupType());
}
IN_PROC_BROWSER_TEST_F(WebSiteSettingsPopupViewBrowserTest,
@@ -49,24 +49,24 @@ IN_PROC_BROWSER_TEST_F(WebSiteSettingsPopupViewBrowserTest,
ui_test_utils::NavigateToURL(
browser(), GURL("chrome-extension://extension-id/options.html"));
ClickAndWait(browser());
- EXPECT_EQ(WebsiteSettingsPopupView::POPUP_INTERNAL_PAGE,
- WebsiteSettingsPopupView::GetShownPopupType());
+ EXPECT_EQ(PageInfoPopupView::POPUP_INTERNAL_PAGE,
+ PageInfoPopupView::GetShownPopupType());
}
IN_PROC_BROWSER_TEST_F(WebSiteSettingsPopupViewBrowserTest, ChromeDevtoolsURL) {
ui_test_utils::NavigateToURL(
browser(), GURL("chrome-devtools://devtools/bundled/inspector.html"));
ClickAndWait(browser());
- EXPECT_EQ(WebsiteSettingsPopupView::POPUP_INTERNAL_PAGE,
- WebsiteSettingsPopupView::GetShownPopupType());
+ EXPECT_EQ(PageInfoPopupView::POPUP_INTERNAL_PAGE,
+ PageInfoPopupView::GetShownPopupType());
}
IN_PROC_BROWSER_TEST_F(WebSiteSettingsPopupViewBrowserTest, ViewSourceURL) {
ui_test_utils::NavigateToURL(browser(), GURL("about:blank"));
chrome::ViewSelectedSource(browser());
ClickAndWait(browser());
- EXPECT_EQ(WebsiteSettingsPopupView::POPUP_INTERNAL_PAGE,
- WebsiteSettingsPopupView::GetShownPopupType());
+ EXPECT_EQ(PageInfoPopupView::POPUP_INTERNAL_PAGE,
+ PageInfoPopupView::GetShownPopupType());
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698