Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4504)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/android/java/res/layout/page_info.xml

Issue 2754383004: Rename WebsiteSettings code to PageInfo. (Closed)
Patch Set: Upload missing comment fix for WebSettingsUI -> PageInfoUI. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/BUILD.gn ('k') | chrome/android/java/res/layout/page_info_permission_row.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/layout/page_info.xml
diff --git a/chrome/android/java/res/layout/website_settings.xml b/chrome/android/java/res/layout/page_info.xml
similarity index 60%
rename from chrome/android/java/res/layout/website_settings.xml
rename to chrome/android/java/res/layout/page_info.xml
index d8f67e09be8d8986fecf3c27bb7c57c91096c0c0..db3a19a8c9f8414e54d0c3aebb1468ab4c807d8b 100644
--- a/chrome/android/java/res/layout/website_settings.xml
+++ b/chrome/android/java/res/layout/page_info.xml
@@ -19,11 +19,11 @@
android:layout_height="wrap_content"
android:orientation="vertical"
android:paddingBottom="12dp"
- android:paddingEnd="@dimen/website_settings_popup_padding_sides"
- android:paddingStart="@dimen/website_settings_popup_padding_sides" >
+ android:paddingEnd="@dimen/page_info_popup_padding_sides"
+ android:paddingStart="@dimen/page_info_popup_padding_sides" >
<view class="org.chromium.chrome.browser.page_info.WebsiteSettingsPopup$ElidedUrlTextView"
- android:id="@+id/website_settings_url"
+ android:id="@+id/page_info_url"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:ellipsize="end"
@@ -34,36 +34,36 @@
android:textSize="16sp"/>
<TextView
- android:id="@+id/website_settings_connection_summary"
+ android:id="@+id/page_info_connection_summary"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:lineSpacingExtra="3dp"
android:paddingTop="16dp"
- android:textColor="@color/website_settings_popup_text"
+ android:textColor="@color/page_info_popup_text"
android:textSize="16sp"
android:visibility="gone" />
<TextView
- android:id="@+id/website_settings_connection_message"
+ android:id="@+id/page_info_connection_message"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:lineSpacingExtra="3dp"
android:paddingTop="8dp"
- android:textColor="@color/website_settings_popup_text"
+ android:textColor="@color/page_info_popup_text"
android:textSize="14sp" />
</LinearLayout>
<org.chromium.ui.widget.ButtonCompat
- android:id="@+id/website_settings_instant_app_button"
+ android:id="@+id/page_info_instant_app_button"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="start"
- android:layout_marginEnd="@dimen/website_settings_popup_padding_sides"
- android:layout_marginStart="@dimen/website_settings_popup_padding_sides"
+ android:layout_marginEnd="@dimen/page_info_popup_padding_sides"
+ android:layout_marginStart="@dimen/page_info_popup_padding_sides"
android:layout_marginTop="12dp"
android:layout_marginBottom="4dp"
- android:paddingEnd="@dimen/website_settings_popup_button_padding_sides"
- android:paddingStart="@dimen/website_settings_popup_button_padding_sides"
+ android:paddingEnd="@dimen/page_info_popup_button_padding_sides"
+ android:paddingStart="@dimen/page_info_popup_button_padding_sides"
android:text="@string/page_info_instant_app_button"
android:textSize="14sp"
android:textColor="@android:color/white"
@@ -71,38 +71,38 @@
chrome:buttonColor="@color/app_banner_install_button_bg" />
<LinearLayout
- android:id="@+id/website_settings_permissions_list"
+ android:id="@+id/page_info_permissions_list"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:orientation="vertical"
- android:paddingStart="@dimen/website_settings_popup_padding_sides"
- android:paddingEnd="@dimen/website_settings_popup_padding_sides" >
+ android:paddingStart="@dimen/page_info_popup_padding_sides"
+ android:paddingEnd="@dimen/page_info_popup_padding_sides" >
</LinearLayout>
<Button
- android:id="@+id/website_settings_site_settings_button"
+ android:id="@+id/page_info_site_settings_button"
android:layout_width="wrap_content"
- android:layout_height="@dimen/website_settings_popup_button_height"
+ android:layout_height="@dimen/page_info_popup_button_height"
android:layout_gravity="end"
- android:layout_marginEnd="@dimen/website_settings_popup_padding_sides"
- android:layout_marginStart="@dimen/website_settings_popup_padding_sides"
+ android:layout_marginEnd="@dimen/page_info_popup_padding_sides"
+ android:layout_marginStart="@dimen/page_info_popup_padding_sides"
android:layout_marginTop="8dp"
- android:paddingEnd="@dimen/website_settings_popup_button_padding_sides"
- android:paddingStart="@dimen/website_settings_popup_button_padding_sides"
+ android:paddingEnd="@dimen/page_info_popup_button_padding_sides"
+ android:paddingStart="@dimen/page_info_popup_button_padding_sides"
android:text="@string/page_info_site_settings_button"
android:textColor="@color/light_active_color"
style="@style/ButtonCompatBorderless" />
<Button
- android:id="@+id/website_settings_open_online_button"
+ android:id="@+id/page_info_open_online_button"
android:layout_width="wrap_content"
- android:layout_height="@dimen/website_settings_popup_button_height"
+ android:layout_height="@dimen/page_info_popup_button_height"
android:layout_gravity="end"
- android:layout_marginEnd="@dimen/website_settings_popup_padding_sides"
- android:layout_marginStart="@dimen/website_settings_popup_padding_sides"
+ android:layout_marginEnd="@dimen/page_info_popup_padding_sides"
+ android:layout_marginStart="@dimen/page_info_popup_padding_sides"
android:layout_marginTop="8dp"
- android:paddingEnd="@dimen/website_settings_popup_button_padding_sides"
- android:paddingStart="@dimen/website_settings_popup_button_padding_sides"
+ android:paddingEnd="@dimen/page_info_popup_button_padding_sides"
+ android:paddingStart="@dimen/page_info_popup_button_padding_sides"
android:text="@string/page_info_open_online_button"
android:textColor="@color/light_active_color"
style="@style/ButtonCompatBorderless" />
« no previous file with comments | « chrome/android/BUILD.gn ('k') | chrome/android/java/res/layout/page_info_permission_row.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698