Require SSE2 support for the ia32 port.

Require SSE2 support for the ia32 port.

R=svenpanne@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=21223

[Sven Panne, 2014-05-07 13:46:03]

LGTM if the comments are addressed *or* if they are handled in separate CL(s).

https://codereview.chromium.org/275433004/diff/1/src/ia32/assembler-ia32.h
File src/ia32/assembler-ia32.h (left):

https://codereview.chromium.org/275433004/diff/1/src/ia32/assembler-ia32.h#ol...
src/ia32/assembler-ia32.h:234: struct X87Register : IntelDoubleRegister {
I think we can nuke/merge IntelDoubleRegister/DoubleRegister now, there is only
a single kind of double registers now.

https://codereview.chromium.org/275433004/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):

https://codereview.chromium.org/275433004/diff/1/src/ia32/code-stubs-ia32.cc#...
src/ia32/code-stubs-ia32.cc:4308: bool CodeStub::CanUseFPRegisters() {
We can nuke CanUseFPRegisters, it is always true on all platforms now.

https://codereview.chromium.org/275433004/diff/1/src/ia32/deoptimizer-ia32.cc
File src/ia32/deoptimizer-ia32.cc (right):

https://codereview.chromium.org/275433004/diff/1/src/ia32/deoptimizer-ia32.cc...
src/ia32/deoptimizer-ia32.cc:234: return
isolate_->builtins()->builtin(Builtins::kNotifyStubFailureSaveDoubles);
I think we always use kNotifyStubFailureSaveDoubles, so the constants and the
parameter can be nuked.

[Yang, 2014-05-07 15:12:25]

On 2014/05/07 13:46:03, Sven Panne wrote:
> LGTM if the comments are addressed *or* if they are handled in separate CL(s).
> 
> https://codereview.chromium.org/275433004/diff/1/src/ia32/assembler-ia32.h
> File src/ia32/assembler-ia32.h (left):
> 
>
https://codereview.chromium.org/275433004/diff/1/src/ia32/assembler-ia32.h#ol...
> src/ia32/assembler-ia32.h:234: struct X87Register : IntelDoubleRegister {
> I think we can nuke/merge IntelDoubleRegister/DoubleRegister now, there is
only
> a single kind of double registers now.
> 
> https://codereview.chromium.org/275433004/diff/1/src/ia32/code-stubs-ia32.cc
> File src/ia32/code-stubs-ia32.cc (right):
> 
>
https://codereview.chromium.org/275433004/diff/1/src/ia32/code-stubs-ia32.cc#...
> src/ia32/code-stubs-ia32.cc:4308: bool CodeStub::CanUseFPRegisters() {
> We can nuke CanUseFPRegisters, it is always true on all platforms now.
> 
> https://codereview.chromium.org/275433004/diff/1/src/ia32/deoptimizer-ia32.cc
> File src/ia32/deoptimizer-ia32.cc (right):
> 
>
https://codereview.chromium.org/275433004/diff/1/src/ia32/deoptimizer-ia32.cc...
> src/ia32/deoptimizer-ia32.cc:234: return
> isolate_->builtins()->builtin(Builtins::kNotifyStubFailureSaveDoubles);
> I think we always use kNotifyStubFailureSaveDoubles, so the constants and the
> parameter can be nuked.

Addressed those comments by ripping out even more stuff.

[Jakob Kummerow, 2014-05-08 10:55:03]

Nice! Some DBC, feel free to postpone to future CLs.

As far as I know, SSE2 effectively implies CMOV, so I think we can rip out all
the "is CMOV supported?" conditionals as well.
(CMOV was introduced in the Pentium Pro in 1995, well before the P4 with SSE2 in
2001. MSVS has always treated the /arch:SSE2 switch to imply CMOV support, see
http://msdn.microsoft.com/en-us/library/7t5yh4fd.aspx)

https://codereview.chromium.org/275433004/diff/20001/src/ia32/assembler-ia32.h
File src/ia32/assembler-ia32.h (right):

https://codereview.chromium.org/275433004/diff/20001/src/ia32/assembler-ia32....
src/ia32/assembler-ia32.h:189: struct XMMRegister : DoubleRegister {
I think you can combine these two classes as well.

[Yang, 2014-05-08 10:58:26]

On 2014/05/08 10:55:03, Jakob wrote:
> Nice! Some DBC, feel free to postpone to future CLs.
> 
> As far as I know, SSE2 effectively implies CMOV, so I think we can rip out all
> the "is CMOV supported?" conditionals as well.
> (CMOV was introduced in the Pentium Pro in 1995, well before the P4 with SSE2
in
> 2001. MSVS has always treated the /arch:SSE2 switch to imply CMOV support, see
> http://msdn.microsoft.com/en-us/library/7t5yh4fd.aspx)
> 
> https://codereview.chromium.org/275433004/diff/20001/src/ia32/assembler-ia32.h
> File src/ia32/assembler-ia32.h (right):
> 
>
https://codereview.chromium.org/275433004/diff/20001/src/ia32/assembler-ia32....
> src/ia32/assembler-ia32.h:189: struct XMMRegister : DoubleRegister {
> I think you can combine these two classes as well.

I wasn't sure about CMOV, but it seems the right thing to do. Will rip it out
after this CL.

[Sven Panne, 2014-05-08 12:13:06]

https://codereview.chromium.org/275433004/diff/20001/src/ia32/assembler-ia32.h
File src/ia32/assembler-ia32.h (right):

https://codereview.chromium.org/275433004/diff/20001/src/ia32/assembler-ia32....
src/ia32/assembler-ia32.h:189: struct XMMRegister : DoubleRegister {
On 2014/05/08 10:55:03, Jakob wrote:
> I think you can combine these two classes as well.

This is what I actually meant with my initial comment, but it seems that I was a
bit unclear about that.

[Yang, 2014-05-09 13:02:20]

Committed patchset #3 manually as r21223 (presubmit successful).