Increase timeout for NavigationItem state update.

Increase timeout for NavigationItem state update.

HistoryStateOperationsTest.StateReplacement and
HistoryStateOperationsTest.StateReplacementBackForward tests are flaky,
failing to complete while waiting for NavigationItem state update.

BUG=684024
Review-Url: https://codereview.chromium.org/2753443002
Cr-Commit-Position: refs/heads/master@{#456547}
Committed: https://chromium.googlesource.com/chromium/src/+/fdddcd9f56e18a8a6a484ea25e6385dba5e1c921

[michaeldo, 2017-03-13 22:40:06]

michaeldo@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-03-13 22:52:53]

eugenebut@chromium.org changed reviewers:
+ kkhorimoto@chromium.org

[Eugene But (OOO till 7-30), 2017-03-13 22:52:53]

lgtm +Kurt

https://codereview.chromium.org/2753443002/diff/1/ios/web/navigation/history_...
File ios/web/navigation/history_state_operations_inttest.mm (right):

https://codereview.chromium.org/2753443002/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:52: const NSTimeInterval
kWaitForStateUpdateTimeout = 5.0;
Did this become flaky after this CL?:
https://codereview.chromium.org/2731283006/patch/60001/70002

or it has always been flaky?

[kkhorimoto, 2017-03-13 23:03:38]

lgtm, but I'm also curious about the answer to Eugene's question.  If adding the
messages introduced flake, we might want to loop some SETIs.

[michaeldo, 2017-03-13 23:26:55]

https://codereview.chromium.org/2753443002/diff/1/ios/web/navigation/history_...
File ios/web/navigation/history_state_operations_inttest.mm (right):

https://codereview.chromium.org/2753443002/diff/1/ios/web/navigation/history_...
ios/web/navigation/history_state_operations_inttest.mm:52: const NSTimeInterval
kWaitForStateUpdateTimeout = 5.0;
On 2017/03/13 22:52:53, Eugene But wrote:
> Did this become flaky after this CL?:
> https://codereview.chromium.org/2731283006/patch/60001/70002
> 
> or it has always been flaky?

It has always been flaky. The messaging simply helped me to identify where the
flake is (mostly) originating. The flake link in the bug shows the flakes have
been fairly consistent for quite a while. Feel free to take a look the recent
failures as I haven't been able to pin down the cause of the flake.
window.replaceState seems to be causing more issues than push.

[michaeldo, 2017-03-13 23:27:25]

The CQ bit was checked by michaeldo@chromium.org

[commit-bot: I haz the power, 2017-03-13 23:28:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 23:40:43]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489447645242050, "parent_rev":
"ffcbf762962091fe257f480dec34781b5864b120", "commit_rev":
"fdddcd9f56e18a8a6a484ea25e6385dba5e1c921"}

[commit-bot: I haz the power, 2017-03-13 23:42:31]

Description was changed from

==========
Increase timeout for NavigationItem state update.

HistoryStateOperationsTest.StateReplacement and
HistoryStateOperationsTest.StateReplacementBackForward tests are flaky,
failing to complete while waiting for NavigationItem state update.

BUG=684024
==========

to

==========
Increase timeout for NavigationItem state update.

HistoryStateOperationsTest.StateReplacement and
HistoryStateOperationsTest.StateReplacementBackForward tests are flaky,
failing to complete while waiting for NavigationItem state update.

BUG=684024

Review-Url: https://codereview.chromium.org/2753443002
Cr-Commit-Position: refs/heads/master@{#456547}
Committed:
https://chromium.googlesource.com/chromium/src/+/fdddcd9f56e18a8a6a484ea25e63...
==========

[commit-bot: I haz the power, 2017-03-13 23:42:31]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fdddcd9f56e18a8a6a484ea25e63...