Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2753443002: Increase timeout for NavigationItem state update. (Closed)

Created:
3 years, 9 months ago by michaeldo
Modified:
3 years, 9 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Increase timeout for NavigationItem state update. HistoryStateOperationsTest.StateReplacement and HistoryStateOperationsTest.StateReplacementBackForward tests are flaky, failing to complete while waiting for NavigationItem state update. BUG=684024 Review-Url: https://codereview.chromium.org/2753443002 Cr-Commit-Position: refs/heads/master@{#456547} Committed: https://chromium.googlesource.com/chromium/src/+/fdddcd9f56e18a8a6a484ea25e6385dba5e1c921

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/web/navigation/history_state_operations_inttest.mm View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 11 (5 generated)
michaeldo
3 years, 9 months ago (2017-03-13 22:40:06 UTC) #2
Eugene But (OOO till 7-30)
lgtm +Kurt https://codereview.chromium.org/2753443002/diff/1/ios/web/navigation/history_state_operations_inttest.mm File ios/web/navigation/history_state_operations_inttest.mm (right): https://codereview.chromium.org/2753443002/diff/1/ios/web/navigation/history_state_operations_inttest.mm#newcode52 ios/web/navigation/history_state_operations_inttest.mm:52: const NSTimeInterval kWaitForStateUpdateTimeout = 5.0; Did this ...
3 years, 9 months ago (2017-03-13 22:52:53 UTC) #4
kkhorimoto
lgtm, but I'm also curious about the answer to Eugene's question. If adding the messages ...
3 years, 9 months ago (2017-03-13 23:03:38 UTC) #5
michaeldo
https://codereview.chromium.org/2753443002/diff/1/ios/web/navigation/history_state_operations_inttest.mm File ios/web/navigation/history_state_operations_inttest.mm (right): https://codereview.chromium.org/2753443002/diff/1/ios/web/navigation/history_state_operations_inttest.mm#newcode52 ios/web/navigation/history_state_operations_inttest.mm:52: const NSTimeInterval kWaitForStateUpdateTimeout = 5.0; On 2017/03/13 22:52:53, Eugene ...
3 years, 9 months ago (2017-03-13 23:26:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2753443002/1
3 years, 9 months ago (2017-03-13 23:28:22 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 23:42:31 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fdddcd9f56e18a8a6a484ea25e63...

Powered by Google App Engine
This is Rietveld 408576698