Increase timeout for NavigationItem state update.

ios/web/navigation/history_state_operations_inttest.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/ptr_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #import "ios/testing/wait_util.h"
 #import "ios/web/navigation/navigation_item_impl.h"
@@ skipping 31 matching lines @@
 const char kPushStateId[] = "push-state";
 const char kReplaceStateId[] = "replace-state";
 
 // JavaScript functions on the history state test page.
 NSString* const kUpdateStateParamsScriptFormat =
     @"updateStateParams('%s', '%s', '%s')";
 NSString* const kOnLoadCheckScript = @"isOnLoadPlaceholderTextVisible()";
 NSString* const kNoOpCheckScript = @"isNoOpPlaceholderTextVisible()";
 
 // Wait timeout for state updates.
-const NSTimeInterval kWaitForStateUpdateTimeout = 2.0;
+const NSTimeInterval kWaitForStateUpdateTimeout = 5.0;

[Eugene But (OOO till 7-30), 2017/03/13 22:52:53]

Did this become flaky after this CL?:
https://codereview.chromium.org/2731283006/patch/60001/70002

or it has always been flaky?

[michaeldo, 2017/03/13 23:26:54]

It has always been flaky. The messaging simply helped me to identify where the
flake is (mostly) originating. The flake link in the bug shows the flakes have
been fairly consistent for quite a while. Feel free to take a look the recent
failures as I haven't been able to pin down the cause of the flake.
window.replaceState seems to be causing more issues than push.

 
 }  // namespace
 
 // Test fixture for integration tests involving html5 window.history state
 // operations.
 class HistoryStateOperationsTest : public web::WebIntTest {
  protected:
   void SetUp() override {
     web::WebIntTest::SetUp();
 
@@ skipping 364 matching lines @@
   // Verify that url has been replaced.
   BOOL completed =
       testing::WaitUntilConditionOrTimeout(kWaitForStateUpdateTimeout, ^{
         return GetLastCommittedItem()->GetURL() == new_url;
       });
   EXPECT_TRUE(completed) << "Failed to validate current url.";
   // Verify that the hashchange event was not fired.
   EXPECT_FALSE(static_cast<web::NavigationItemImpl*>(GetLastCommittedItem())
                    ->IsCreatedFromHashChange());
 }