ios/web/navigation/history_state_operations_inttest.mm - Issue 2753443002: Increase timeout for NavigationItem state update.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/navigation/history_state_operations_inttest.mm

Issue 2753443002: Increase timeout for NavigationItem state update. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/navigation/history_state_operations_inttest.mm

diff --git a/ios/web/navigation/history_state_operations_inttest.mm b/ios/web/navigation/history_state_operations_inttest.mm

index 84b0d5018757115def7f7800b1d64f6a4b610388..d4b977533b171c69d7ba61caa58e5b444966fbba 100644

--- a/ios/web/navigation/history_state_operations_inttest.mm

+++ b/ios/web/navigation/history_state_operations_inttest.mm

@@ -49,7 +49,7 @@ NSString* const kOnLoadCheckScript = @"isOnLoadPlaceholderTextVisible()";

NSString* const kNoOpCheckScript = @"isNoOpPlaceholderTextVisible()";

// Wait timeout for state updates.

-const NSTimeInterval kWaitForStateUpdateTimeout = 2.0;

+const NSTimeInterval kWaitForStateUpdateTimeout = 5.0;

Eugene But (OOO till 7-30) 2017/03/13 22:52:53 Did this become flaky after this CL?: https://code

michaeldo 2017/03/13 23:26:54 It has always been flaky. The messaging simply hel

} // namespace

« no previous file with comments | « no previous file | no next file » | no next file with comments »