DCHECK that the security origin for a media request isn't empty

DCHECK that the security origin for a media request isn't empty

Currently we return an error if the origin for a media request is empty.
However it doesn't appear that this codepath can be reached even by following
the instructions on the comment associated with the code. Add a DCHECK that
this can't happen instead.

The enum value isn't removed because it's used in a histogram, instead it's
renamed with _DEPRECATED. We may also want to use it at a later time.

BUG=596786
Review-Url: https://codereview.chromium.org/2753013002
Cr-Commit-Position: refs/heads/master@{#462259}
Committed: https://chromium.googlesource.com/chromium/src/+/ba45071136a37deb60e5ce17d25432a7f2e9aeae

[raymes, 2017-03-16 02:44:37]

The CQ bit was checked by raymes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 02:44:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 04:18:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 04:19:00]

Dry run: This issue passed the CQ dry run.

[raymes, 2017-04-04 03:05:52]

Description was changed from

==========
DCHECK that the security origin for a media request isn't empty

Currently we return an error if the origin for a media request is
empty. However it doesn't appear that this codepath can be reached
at least not by following the instructions on the comment
associated with the code. Add a DCHECK that this can't happen
instead.

BUG=596786
==========

to

==========
DCHECK that the security origin for a media request isn't empty

Currently we return an error if the origin for a media request is empty.
However it doesn't appear that this codepath can be reached even by following
the instructions on the comment associated with the code. Add a DCHECK that
this can't happen instead.

The enum value isn't removed because it's used in a histogram, instead it's
renamed with _DEPRECATED. We may also want to use it at a later time.

BUG=596786
==========

[raymes, 2017-04-04 03:06:20]

The CQ bit was checked by raymes@chromium.org to run a CQ dry run

[raymes, 2017-04-04 03:06:28]

raymes@chromium.org changed reviewers:
+ sergeyu@chromium.org

[commit-bot: I haz the power, 2017-04-04 03:06:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 04:55:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 04:55:13]

Dry run: This issue passed the CQ dry run.

[Sergey Ulanov, 2017-04-04 16:59:30]

lgtm

[raymes, 2017-04-04 21:55:28]

raymes@chromium.org changed reviewers:
+ kinuko@chromium.org

[raymes, 2017-04-04 21:55:29]

+kinuko for content/public. I actually only just realized that the enum lived in
content/public. If you think renaming the enum is problematic I can leave it the
same as before. Thanks!

[kinuko, 2017-04-05 07:53:19]

lgtm

[raymes, 2017-04-05 21:48:11]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2017-04-05 21:48:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 23:11:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491428891501660,
"parent_rev": "5b97f21d9cd473b57b8ce169f75d9cdc135184fc", "commit_rev":
"ba45071136a37deb60e5ce17d25432a7f2e9aeae"}

[commit-bot: I haz the power, 2017-04-05 23:11:49]

Description was changed from

==========
DCHECK that the security origin for a media request isn't empty

Currently we return an error if the origin for a media request is empty.
However it doesn't appear that this codepath can be reached even by following
the instructions on the comment associated with the code. Add a DCHECK that
this can't happen instead.

The enum value isn't removed because it's used in a histogram, instead it's
renamed with _DEPRECATED. We may also want to use it at a later time.

BUG=596786
==========

to

==========
DCHECK that the security origin for a media request isn't empty

Currently we return an error if the origin for a media request is empty.
However it doesn't appear that this codepath can be reached even by following
the instructions on the comment associated with the code. Add a DCHECK that
this can't happen instead.

The enum value isn't removed because it's used in a histogram, instead it's
renamed with _DEPRECATED. We may also want to use it at a later time.

BUG=596786

Review-Url: https://codereview.chromium.org/2753013002
Cr-Commit-Position: refs/heads/master@{#462259}
Committed:
https://chromium.googlesource.com/chromium/src/+/ba45071136a37deb60e5ce17d254...
==========

[commit-bot: I haz the power, 2017-04-05 23:11:52]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ba45071136a37deb60e5ce17d254...