Remove IsUserAcceptAllowed check from storing media permission decision

Remove IsUserAcceptAllowed check from storing media permission decision

IsUserAcceptAllowed returns whether the Android permission can be granted as
well as whether the tab is showing. These things are important to check when
deciding whether permission should be granted to an origin, but they are not
important to check when deciding whether to store a permission decision a user
has made. As such we can remove this check.

BUG=596786
Review-Url: https://codereview.chromium.org/2801553002
Cr-Commit-Position: refs/heads/master@{#463164}
Committed: https://chromium.googlesource.com/chromium/src/+/93b8c34db71156846a5c60d71b8ae447cbd5165a

[raymes, 2017-04-05 01:29:18]

raymes@chromium.org changed reviewers:
+ timloh@chromium.org

[raymes, 2017-04-05 01:29:35]

Description was changed from

==========
Remove IsUserAcceptAllowed check from storing permission decision

IsUserAcceptAllowed returns whether the Android permission can be granted as
well as whether the tab is showing. These things are important to check when
deciding whether permission should be granted to an origin, but they are not
important to check when deciding whether to store a permission decision a user
has made. As such we can remove this check.

BUG=596786
==========

to

==========
Remove IsUserAcceptAllowed check from storing media permission decision

IsUserAcceptAllowed returns whether the Android permission can be granted as
well as whether the tab is showing. These things are important to check when
deciding whether permission should be granted to an origin, but they are not
important to check when deciding whether to store a permission decision a user
has made. As such we can remove this check.

BUG=596786
==========

[Timothy Loh, 2017-04-06 01:38:41]

On 2017/04/05 01:29:18, raymes wrote:

Seems reasonable, lgtm

[raymes, 2017-04-09 23:46:01]

The CQ bit was checked by raymes@chromium.org

[commit-bot: I haz the power, 2017-04-09 23:46:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 01:29:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491781561410430,
"parent_rev": "718823aa31aecf6aad1751407ac2c55ce26cf88e", "commit_rev":
"93b8c34db71156846a5c60d71b8ae447cbd5165a"}

[commit-bot: I haz the power, 2017-04-10 01:30:42]

Description was changed from

==========
Remove IsUserAcceptAllowed check from storing media permission decision

IsUserAcceptAllowed returns whether the Android permission can be granted as
well as whether the tab is showing. These things are important to check when
deciding whether permission should be granted to an origin, but they are not
important to check when deciding whether to store a permission decision a user
has made. As such we can remove this check.

BUG=596786
==========

to

==========
Remove IsUserAcceptAllowed check from storing media permission decision

IsUserAcceptAllowed returns whether the Android permission can be granted as
well as whether the tab is showing. These things are important to check when
deciding whether permission should be granted to an origin, but they are not
important to check when deciding whether to store a permission decision a user
has made. As such we can remove this check.

BUG=596786

Review-Url: https://codereview.chromium.org/2801553002
Cr-Commit-Position: refs/heads/master@{#463164}
Committed:
https://chromium.googlesource.com/chromium/src/+/93b8c34db71156846a5c60d71b8a...
==========

[commit-bot: I haz the power, 2017-04-10 01:30:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/93b8c34db71156846a5c60d71b8a...