[Doodle] Make DoodleService a KeyedService and add a factory

[Doodle] Make DoodleService a KeyedService and add a factory

BUG=690467
Review-Url: https://codereview.chromium.org/2752563003
Cr-Commit-Position: refs/heads/master@{#457716}
Committed: https://chromium.googlesource.com/chromium/src/+/f89d1a7d3451486b5da9161b62725e98a09fa802

[Marc Treib, 2017-03-14 10:50:12]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 10:50:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 11:16:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 11:16:08]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Marc Treib, 2017-03-14 11:25:18]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 11:25:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 12:42:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 12:42:36]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2017-03-14 13:26:50]

treib@chromium.org changed reviewers:
+ bauerb@chromium.org

[Marc Treib, 2017-03-14 13:26:50]

PTAL!

https://codereview.chromium.org/2752563003/diff/20001/chrome/browser/android/...
File chrome/browser/android/doodle_service_factory.h (right):

https://codereview.chromium.org/2752563003/diff/20001/chrome/browser/android/...
chrome/browser/android/doodle_service_factory.h:6: #define
CHROME_BROWSER_ANDROID_DOODLE_SERVICE_FACTORY_H_
For now, this is only used on Android. Eventually it'll be used on desktop too,
but that's still a good while out. Do you think it's better to put this here for
now, or directly put it into c/b/?

[Bernhard Bauer, 2017-03-14 16:45:42]

LGTM, although moving the factory might be nice:

https://codereview.chromium.org/2752563003/diff/20001/chrome/browser/android/...
File chrome/browser/android/doodle_service_factory.h (right):

https://codereview.chromium.org/2752563003/diff/20001/chrome/browser/android/...
chrome/browser/android/doodle_service_factory.h:6: #define
CHROME_BROWSER_ANDROID_DOODLE_SERVICE_FACTORY_H_
On 2017/03/14 13:26:50, Marc Treib wrote:
> For now, this is only used on Android. Eventually it'll be used on desktop
too,
> but that's still a good while out. Do you think it's better to put this here
for
> now, or directly put it into c/b/?

I think I would put it into c/b/ if there's conceptually nothing in there that
ties it to Android.

[Marc Treib, 2017-03-15 09:34:02]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 09:34:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2017-03-15 09:34:28]

https://codereview.chromium.org/2752563003/diff/20001/chrome/browser/android/...
File chrome/browser/android/doodle_service_factory.h (right):

https://codereview.chromium.org/2752563003/diff/20001/chrome/browser/android/...
chrome/browser/android/doodle_service_factory.h:6: #define
CHROME_BROWSER_ANDROID_DOODLE_SERVICE_FACTORY_H_
On 2017/03/14 16:45:42, Bernhard Bauer wrote:
> On 2017/03/14 13:26:50, Marc Treib wrote:
> > For now, this is only used on Android. Eventually it'll be used on desktop
> too,
> > but that's still a good while out. Do you think it's better to put this here
> for
> > now, or directly put it into c/b/?
> 
> I think I would put it into c/b/ if there's conceptually nothing in there that
> ties it to Android.

Done, moved to a new folder c/b/doodle/

[Marc Treib, 2017-03-15 09:37:22]

treib@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[Marc Treib, 2017-03-15 09:37:22]

+phajdan.jr for new DEPS from components/doodle to
components/keyed_service/core. PTAL!

[commit-bot: I haz the power, 2017-03-15 10:52:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 10:52:56]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2017-03-16 09:25:49]

treib@chromium.org changed reviewers:
+ jochen@chromium.org

[Marc Treib, 2017-03-16 09:25:49]

+jochen for new folder chrome/browser/doodle, PTAL!

Also friendly ping phajdan.jr!

[Paweł Hajdan Jr., 2017-03-16 16:20:30]

LGTM

[jochen (gone - plz use gerrit), 2017-03-16 19:14:16]

lgtm

[Marc Treib, 2017-03-16 21:17:41]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2017-03-16 21:17:42]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2752563003/#ps40001
(title: "Move factory to c/b/doodle")

[commit-bot: I haz the power, 2017-03-16 21:18:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 22:32:02]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489699061786270,
"parent_rev": "b920cc2cead86781d5c5882a22ed09793b144d63", "commit_rev":
"32746f132c9dc06680abf467aa870b2e7d121ca7"}

[commit-bot: I haz the power, 2017-03-16 22:39:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 22:39:05]

Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

[Marc Treib, 2017-03-17 08:42:17]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2017-03-17 08:42:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 08:46:28]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489740137413680,
"parent_rev": "2b9e4d03756be0ca4867bc1a03f8bd69f3eed43b", "commit_rev":
"f89d1a7d3451486b5da9161b62725e98a09fa802"}

[commit-bot: I haz the power, 2017-03-17 08:47:11]

Description was changed from

==========
[Doodle] Make DoodleService a KeyedService and add a factory

BUG=690467
==========

to

==========
[Doodle] Make DoodleService a KeyedService and add a factory

BUG=690467

Review-Url: https://codereview.chromium.org/2752563003
Cr-Commit-Position: refs/heads/master@{#457716}
Committed:
https://chromium.googlesource.com/chromium/src/+/f89d1a7d3451486b5da9161b6272...
==========

[commit-bot: I haz the power, 2017-03-17 08:47:13]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f89d1a7d3451486b5da9161b6272...