Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2747423002: Cleanup: Remove LogoBridge instance from NewTabPage (Closed)

Created:
3 years, 9 months ago by Marc Treib
Modified:
3 years, 9 months ago
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove LogoBridge instance from NewTabPage It's unused, and creating the instance can trigger an unnecessary network request to refresh the doodle. BUG=none Review-Url: https://codereview.chromium.org/2747423002 Cr-Commit-Position: refs/heads/master@{#457058} Committed: https://chromium.googlesource.com/chromium/src/+/0c11ce1f9bfd57fc57328d5d3ee6bb4fd451207d

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 3 chunks +0 lines, -6 lines 1 comment Download

Messages

Total messages: 12 (8 generated)
Marc Treib
PTAL!
3 years, 9 months ago (2017-03-15 11:08:45 UTC) #4
Michael van Ouwerkerk
lgtm https://codereview.chromium.org/2747423002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java (left): https://codereview.chromium.org/2747423002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java#oldcode90 chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java:90: private LogoBridge mLogoBridge; Thanks Marc! Looks like I ...
3 years, 9 months ago (2017-03-15 11:12:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747423002/20001
3 years, 9 months ago (2017-03-15 11:58:57 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 12:08:47 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0c11ce1f9bfd57fc57328d5d3ee6...

Powered by Google App Engine
This is Rietveld 408576698