Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2749813002: [Doodle] Hook up LogoBridge to the new DoodleService (Closed)

Created:
3 years, 9 months ago by Marc Treib
Modified:
3 years, 9 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Doodle] Hook up LogoBridge to the new DoodleService Hidden behind a flag, so no user-visible changes yet. BUG=690467 Review-Url: https://codereview.chromium.org/2749813002 Cr-Commit-Position: refs/heads/master@{#457769} Committed: https://chromium.googlesource.com/chromium/src/+/72fb3888ae3ae20cc2706f5a6152bdce3a75b796

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : disable by default #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -21 lines) Patch
M chrome/browser/android/logo_bridge.h View 1 2 3 2 chunks +42 lines, -2 lines 0 comments Download
M chrome/browser/android/logo_bridge.cc View 1 2 3 4 6 chunks +121 lines, -19 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Marc Treib
PTAL!
3 years, 9 months ago (2017-03-17 14:23:40 UTC) #7
Marc Treib
3 years, 9 months ago (2017-03-17 14:27:19 UTC) #9
Bernhard Bauer
lgtm
3 years, 9 months ago (2017-03-17 14:51:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749813002/80001
3 years, 9 months ago (2017-03-17 14:53:32 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 14:59:44 UTC) #15
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/72fb3888ae3ae20cc2706f5a6152...

Powered by Google App Engine
This is Rietveld 408576698