Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2752373002: Use PrintWindow() to implement snapshots on windows 8.1+ (Closed)

Created:
3 years, 9 months ago by jbauman
Modified:
3 years, 8 months ago
Reviewers:
ananta, sky, piman
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use PrintWindow() to implement snapshots on windows 8.1+ This allows us to capture what DirectComposition is actually displaying and make GPU integration tests able to detect more possible problems. The existing Aura capture path is used on Windows versions before 8.1, because they don't support PW_RENDERFULLCONTENT and then PrintWindow may not get the correct content. NativeDesktopMediaList::CaptureAuraWindowThumbnail also will use the aura path, because it's used in production for webrtc and needs to be efficient. BUG=702023 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2752373002 Cr-Commit-Position: refs/heads/master@{#462631} Committed: https://chromium.googlesource.com/chromium/src/+/0c2c9631a434330c2982f0062a159f167879e2e8

Patch Set 1 #

Patch Set 2 : Fix BUILD.gn #

Patch Set 3 : fix high-dpi #

Patch Set 4 : fix osmesa #

Patch Set 5 : fix aura build #

Patch Set 6 : use aura for win7 #

Patch Set 7 : cleanup #

Patch Set 8 : cleanup #

Total comments: 5

Patch Set 9 : post-review changes #

Patch Set 10 : fix build #

Total comments: 2

Patch Set 11 : rename variables #

Patch Set 12 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+314 lines, -56 lines) Patch
M chrome/browser/media/webrtc/native_desktop_media_list.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +6 lines, -5 lines 0 comments Download
M ui/gl/gl_surface_osmesa_win.cc View 1 2 3 4 5 6 7 3 chunks +7 lines, -29 lines 0 comments Download
M ui/snapshot/BUILD.gn View 1 2 3 4 5 6 7 8 3 chunks +25 lines, -2 lines 0 comments Download
A ui/snapshot/snapshot_aura.h View 1 2 3 4 5 6 7 8 1 chunk +30 lines, -0 lines 0 comments Download
M ui/snapshot/snapshot_aura.cc View 1 2 3 4 5 6 7 8 9 6 chunks +45 lines, -19 lines 0 comments Download
A ui/snapshot/snapshot_win.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +36 lines, -0 lines 0 comments Download
A ui/snapshot/snapshot_win.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +160 lines, -0 lines 0 comments Download

Messages

Total messages: 76 (64 generated)
jbauman
3 years, 9 months ago (2017-03-23 01:16:24 UTC) #39
sky
+ananta for snapshot_win.cc I'm rather nervous about using an undocumented flag. Seems easy for us ...
3 years, 9 months ago (2017-03-23 03:29:14 UTC) #41
jbauman
PTAL On 2017/03/23 03:29:14, sky wrote: > +ananta for snapshot_win.cc > > I'm rather nervous ...
3 years, 9 months ago (2017-03-23 20:59:59 UTC) #50
sky
https://codereview.chromium.org/2752373002/diff/180001/ui/snapshot/snapshot_win.cc File ui/snapshot/snapshot_win.cc (right): https://codereview.chromium.org/2752373002/diff/180001/ui/snapshot/snapshot_win.cc#newcode36 ui/snapshot/snapshot_win.cc:36: const gfx::Rect& snapshot_bounds, Please name these in pixels. https://codereview.chromium.org/2752373002/diff/180001/ui/snapshot/snapshot_win.cc#newcode101 ...
3 years, 9 months ago (2017-03-23 23:20:33 UTC) #51
jbauman
On 2017/03/23 23:20:33, sky wrote: > https://codereview.chromium.org/2752373002/diff/180001/ui/snapshot/snapshot_win.cc > File ui/snapshot/snapshot_win.cc (right): > > https://codereview.chromium.org/2752373002/diff/180001/ui/snapshot/snapshot_win.cc#newcode36 > ...
3 years, 9 months ago (2017-03-24 23:31:52 UTC) #54
sky
LGTM
3 years, 9 months ago (2017-03-27 15:36:19 UTC) #57
jbauman
ananta, does the GrabHwndSnapshot part seem ok?
3 years, 8 months ago (2017-03-27 23:09:56 UTC) #58
jbauman
piman: content/ OWNERS review.
3 years, 8 months ago (2017-04-06 01:08:51 UTC) #68
ananta
LGTM
3 years, 8 months ago (2017-04-06 01:27:06 UTC) #69
piman
lgtm
3 years, 8 months ago (2017-04-06 20:51:40 UTC) #70
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752373002/210001
3 years, 8 months ago (2017-04-06 21:06:37 UTC) #73
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 21:44:38 UTC) #76
Message was sent while issue was closed.
Committed patchset #12 (id:210001) as
https://chromium.googlesource.com/chromium/src/+/0c2c9631a434330c2982f0062a15...

Powered by Google App Engine
This is Rietveld 408576698