Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2751973002: MIPS: Move ldc1/sdc1 to macro-assembler. (Closed)

Created:
3 years, 9 months ago by Ilija.Pavlovic1
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Move ldc1/sdc1 to macro-assembler. For MIPS32, instructions ldc1 and sdc1 are moved into macro-assembler and renamed as Ldc1 and Sdc1. The reason for placing them into macro-assembler is that they emmit two or three instructions. TEST=test/cctest/test-assembler-mips, test/cctest/test-code-stubs-mips, test/cctest/test-macro-assembler-mips BUG= Review-Url: https://codereview.chromium.org/2751973002 Cr-Commit-Position: refs/heads/master@{#43977} Committed: https://chromium.googlesource.com/v8/v8/+/47da8de250ca2b9ba37f69d7520bbf9df1ab127d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+336 lines, -346 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 12 chunks +15 lines, -15 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 17 chunks +20 lines, -20 lines 0 comments Download
M src/crankshaft/mips/lithium-gap-resolver-mips.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M src/mips/assembler-mips.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips/assembler-mips.cc View 2 chunks +0 lines, -78 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M src/mips/deoptimizer-mips.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 13 chunks +81 lines, -12 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 45 chunks +188 lines, -188 lines 0 comments Download
M test/cctest/test-code-stubs-mips.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-macro-assembler-mips.cc View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Ilija.Pavlovic1
PTAL
3 years, 9 months ago (2017-03-15 14:16:42 UTC) #3
Ilija.Pavlovic1
PTAL
3 years, 9 months ago (2017-03-15 14:16:42 UTC) #4
miran.karic
lgtm
3 years, 9 months ago (2017-03-15 14:29:12 UTC) #6
ivica.bogosavljevic
lgtm
3 years, 9 months ago (2017-03-21 09:39:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751973002/1
3 years, 9 months ago (2017-03-21 11:13:09 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 11:35:47 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/47da8de250ca2b9ba37f69d7520bbf9df1a...

Powered by Google App Engine
This is Rietveld 408576698