NTP: track shown/blocked suggestions notifications

NTP: track shown/blocked suggestions notifications

BUG=702301
Review-Url: https://codereview.chromium.org/2751913005
Cr-Commit-Position: refs/heads/master@{#457719}
Committed: https://chromium.googlesource.com/chromium/src/+/4438031f49371167f327ffcffbb3d9a11996e9b8

[sfiera, 2017-03-16 18:40:06]

The CQ bit was checked by sfiera@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 18:40:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sfiera, 2017-03-16 18:42:14]

sfiera@chromium.org changed reviewers:
+ asvitkine@chromium.org, dgn@chromium.org, peter@chromium.org

[sfiera, 2017-03-16 18:42:15]

peter: for NotificationUmaTracker.java
dgn: for ContentSuggestionsNotificationHelper.java
asvitkine: for histograms.xml (I think the guidance is, TBR is OK when updating
an enum, so I won't wait for you)

I should have found this and integrated our notifications with it earlier, but
better late than never.

[Alexei Svitkine (slow), 2017-03-16 18:43:22]

lgtm

[Peter Beverloo, 2017-03-16 18:44:42]

lgtm

[dgn, 2017-03-16 19:32:26]

lgtm

https://codereview.chromium.org/2751913005/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java
(right):

https://codereview.chromium.org/2751913005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java:25:
SYSTEM_NOTIFICATION_TYPE_BOUNDARY})
Unrelated: IMO SYSTEM_NOTIFICATION_TYPE_BOUNDARY should not be in the enum, as
it's not really a valid value. But that has nothing to do with this CL and it's
private anyway ¯\_(ツ)_/¯

[commit-bot: I haz the power, 2017-03-16 20:00:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 20:00:46]

Dry run: This issue passed the CQ dry run.

[sfiera, 2017-03-17 08:57:57]

The CQ bit was checked by sfiera@chromium.org

[commit-bot: I haz the power, 2017-03-17 08:58:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 09:02:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489741077335550, "parent_rev":
"56b1ac1be5b34735541c864d6de5b61e3091258d", "commit_rev":
"4438031f49371167f327ffcffbb3d9a11996e9b8"}

[commit-bot: I haz the power, 2017-03-17 09:03:27]

Description was changed from

==========
NTP: track shown/blocked suggestions notifications

BUG=702301
==========

to

==========
NTP: track shown/blocked suggestions notifications

BUG=702301

Review-Url: https://codereview.chromium.org/2751913005
Cr-Commit-Position: refs/heads/master@{#457719}
Committed:
https://chromium.googlesource.com/chromium/src/+/4438031f49371167f327ffcffbb3...
==========

[commit-bot: I haz the power, 2017-03-17 09:03:28]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4438031f49371167f327ffcffbb3...