Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issue 2751913005: NTP: track shown/blocked suggestions notifications (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by sfiera
Modified:
4 months, 1 week ago
CC:
chromium-reviews, awdf+watch_chromium.org, ntp-dev+reviews_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, noyau+watch_chromium.org, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NTP: track shown/blocked suggestions notifications BUG=702301 Review-Url: https://codereview.chromium.org/2751913005 Cr-Commit-Position: refs/heads/master@{#457719} Committed: https://chromium.googlesource.com/chromium/src/+/4438031f49371167f327ffcffbb3d9a11996e9b8

Patch Set 1 #

Total comments: 1

Messages

Total messages: 14 (8 generated)
sfiera
peter: for NotificationUmaTracker.java dgn: for ContentSuggestionsNotificationHelper.java asvitkine: for histograms.xml (I think the guidance is, TBR ...
4 months, 1 week ago (2017-03-16 18:42:15 UTC) #4
Alexei Svitkine (OOO til Aug6)
lgtm
4 months, 1 week ago (2017-03-16 18:43:22 UTC) #5
Peter Beverloo
lgtm
4 months, 1 week ago (2017-03-16 18:44:42 UTC) #6
dgn
lgtm https://codereview.chromium.org/2751913005/diff/1/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java File chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java (right): https://codereview.chromium.org/2751913005/diff/1/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java#newcode25 chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java:25: SYSTEM_NOTIFICATION_TYPE_BOUNDARY}) Unrelated: IMO SYSTEM_NOTIFICATION_TYPE_BOUNDARY should not be in ...
4 months, 1 week ago (2017-03-16 19:32:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751913005/1
4 months, 1 week ago (2017-03-17 08:58:11 UTC) #11
commit-bot: I haz the power
4 months, 1 week ago (2017-03-17 09:03:28 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4438031f49371167f327ffcffbb3...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 25c286973