Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java

Issue 2751913005: NTP: track shown/blocked suggestions notifications (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java
index d97bf8f9163f5ee8504adadbaea06804e37be1da..bf85281f2e046702ca76fd62ef7e6315521fcf6c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java
@@ -21,7 +21,8 @@ import java.lang.annotation.RetentionPolicy;
*/
public class NotificationUmaTracker {
@Retention(RetentionPolicy.SOURCE)
- @IntDef({DOWNLOAD_FILES, DOWNLOAD_PAGES, CLOSE_INCOGNITO, SYSTEM_NOTIFICATION_TYPE_BOUNDARY})
+ @IntDef({DOWNLOAD_FILES, DOWNLOAD_PAGES, CLOSE_INCOGNITO, CONTENT_SUGGESTION,
+ SYSTEM_NOTIFICATION_TYPE_BOUNDARY})
dgn 2017/03/16 19:32:26 Unrelated: IMO SYSTEM_NOTIFICATION_TYPE_BOUNDARY s
public @interface SystemNotificationType {}
/*
@@ -34,8 +35,9 @@ public class NotificationUmaTracker {
public static final int DOWNLOAD_FILES = 0;
public static final int DOWNLOAD_PAGES = 1;
public static final int CLOSE_INCOGNITO = 2;
+ public static final int CONTENT_SUGGESTION = 3;
- private static final int SYSTEM_NOTIFICATION_TYPE_BOUNDARY = 3;
+ private static final int SYSTEM_NOTIFICATION_TYPE_BOUNDARY = 4;
private static final String LAST_SHOWN_NOTIFICATION_TYPE_KEY =
"NotificationUmaTracker.LastShownNotificationType";
@@ -90,4 +92,4 @@ public class NotificationUmaTracker {
if (!LibraryLoader.isInitialized()) return;
RecordHistogram.recordEnumeratedHistogram(name, type, SYSTEM_NOTIFICATION_TYPE_BOUNDARY);
}
-}
+}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698