chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java - Issue 2751913005: NTP: track shown/blocked suggestions notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java

Issue 2751913005: NTP: track shown/blocked suggestions notifications (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java

index b27ee4952603d48c7836e886e5f12522f376f8a8..0ce1c17e5dbda5b05b319a397d3f35f0ba7cfa63 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotificationHelper.java

@@ -27,6 +27,7 @@ import org.chromium.chrome.browser.ShortcutHelper;

import org.chromium.chrome.browser.document.ChromeLauncherActivity;

import org.chromium.chrome.browser.notifications.ChromeNotificationBuilder;

import org.chromium.chrome.browser.notifications.NotificationConstants;

+import org.chromium.chrome.browser.notifications.NotificationUmaTracker;

import org.chromium.chrome.browser.ntp.snippets.ContentSuggestionsNotificationAction;

import java.util.Collection;

@@ -169,6 +170,8 @@ public class ContentSuggestionsNotificationHelper {

builder.setDefaults(Notification.DEFAULT_ALL);

}

manager.notify(NOTIFICATION_TAG, nextId, builder.build());

+ NotificationUmaTracker.getInstance().onNotificationShown(

+ NotificationUmaTracker.CONTENT_SUGGESTION);

addActiveNotification(new ActiveNotification(nextId, category, idWithinCategory, uri));

// Set timeout.