third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/user-agent-override.html - Issue 2751193003: [DevTools] Move ConsoleModel to it's own module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/user-agent-override.html

Issue 2751193003: [DevTools] Move ConsoleModel to it's own module (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js ('k') | third_party/WebKit/LayoutTests/inspector/console/console-eval-throw.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/user-agent-override.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/user-agent-override.html b/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/user-agent-override.html

index 61d0ab0826e07d8595ecb6ffc0f70c7bfab7f685..c1908f82cb56d73ad18068f6452c5cfa99e4f540 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/user-agent-override.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/user-agent-override.html

@@ -30,13 +30,13 @@ function test()

function waitForConsoleMessage(regex)

{

return new Promise(function(resolve) {

- SDK.consoleModel.addEventListener(SDK.ConsoleModel.Events.MessageAdded, sniff);

+ ConsoleModel.consoleModel.addEventListener(ConsoleModel.ConsoleModel.Events.MessageAdded, sniff);

function sniff(e)

{

if (e.data && regex.test(e.data.messageText)) {

resolve(e.data);

- SDK.consoleModel.removeEventListener(SDK.ConsoleModel.Events.MessageAdded, sniff);

+ ConsoleModel.consoleModel.removeEventListener(ConsoleModel.ConsoleModel.Events.MessageAdded, sniff);

}

});