Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2750503003: Register type constants through ConstantUse (Closed)

Created:
3 years, 9 months ago by Johnni Winther
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -40 lines) Patch
M pkg/compiler/lib/src/common/codegen.dart View 4 chunks +0 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen_listener.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/impact_transformer.dart View 4 chunks +0 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 1 chunk +0 lines, -13 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 9 months ago (2017-03-13 14:39:27 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2750503003/diff/1/pkg/compiler/lib/src/ssa/codegen.dart File pkg/compiler/lib/src/ssa/codegen.dart (left): https://codereview.chromium.org/2750503003/diff/1/pkg/compiler/lib/src/ssa/codegen.dart#oldcode2077 pkg/compiler/lib/src/ssa/codegen.dart:2077: registry.registerStaticUse(new StaticUse.staticTearOff(function.element)); I saw the changes below in ...
3 years, 9 months ago (2017-03-14 05:48:40 UTC) #3
Johnni Winther
https://codereview.chromium.org/2750503003/diff/1/pkg/compiler/lib/src/ssa/codegen.dart File pkg/compiler/lib/src/ssa/codegen.dart (left): https://codereview.chromium.org/2750503003/diff/1/pkg/compiler/lib/src/ssa/codegen.dart#oldcode2077 pkg/compiler/lib/src/ssa/codegen.dart:2077: registry.registerStaticUse(new StaticUse.staticTearOff(function.element)); On 2017/03/14 05:48:40, Siggi Cherem (dart-lang) wrote: ...
3 years, 9 months ago (2017-03-15 13:47:05 UTC) #4
Johnni Winther
3 years, 9 months ago (2017-03-15 13:52:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4414836936cc6f51dbbcc5d11bcee3bfd42ddd66 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698