Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: pkg/compiler/lib/src/ssa/codegen.dart

Issue 2750503003: Register type constants through ConstantUse (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_backend/impact_transformer.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/codegen.dart
diff --git a/pkg/compiler/lib/src/ssa/codegen.dart b/pkg/compiler/lib/src/ssa/codegen.dart
index a3f2be1fca03edc26a622b579603a36a614f7db9..ab3857ecc8a39252d6dac0df06de52702c9c9e17 100644
--- a/pkg/compiler/lib/src/ssa/codegen.dart
+++ b/pkg/compiler/lib/src/ssa/codegen.dart
@@ -2072,19 +2072,6 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
void generateConstant(
ConstantValue constant, SourceInformation sourceInformation) {
- if (constant.isFunction) {
- FunctionConstantValue function = constant;
- registry.registerStaticUse(new StaticUse.staticTearOff(function.element));
Siggi Cherem (dart-lang) 2017/03/14 05:48:40 I saw the changes below in the listener, but is th
Johnni Winther 2017/03/15 13:47:05 Yes.
- }
- if (constant.isType) {
- // If the type is a web component, we need to ensure the constructors are
- // available to 'upgrade' the native object.
- TypeConstantValue type = constant;
- if (type.representedType.isInterfaceType) {
- InterfaceType representedType = type.representedType;
- registry.registerTypeConstant(representedType.element);
- }
- }
js.Expression expression = backend.emitter.constantReference(constant);
if (!constant.isDummy) {
// TODO(johnniwinther): Support source information on synthetic constants.
« no previous file with comments | « pkg/compiler/lib/src/js_backend/impact_transformer.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698