Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: pkg/compiler/lib/src/common/codegen.dart

Issue 2750503003: Register type constants through ConstantUse (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_backend/backend.dart » ('j') | pkg/compiler/lib/src/ssa/codegen.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/common/codegen.dart
diff --git a/pkg/compiler/lib/src/common/codegen.dart b/pkg/compiler/lib/src/common/codegen.dart
index 6ac632897cb19cd2dd74a14b442a3655705506b7..dea9ca481a3105c01e6a41f4ba16122d1584cf1d 100644
--- a/pkg/compiler/lib/src/common/codegen.dart
+++ b/pkg/compiler/lib/src/common/codegen.dart
@@ -39,8 +39,6 @@ class CodegenImpact extends WorldImpact {
bool get usesInterceptor => false;
- Iterable<ClassElement> get typeConstants => const <ClassElement>[];
-
Iterable<Element> get asyncMarkers => const <FunctionElement>[];
}
@@ -50,7 +48,6 @@ class _CodegenImpact extends WorldImpactBuilderImpl implements CodegenImpact {
Setlet<String> _constSymbols;
List<Set<ClassElement>> _specializedGetInterceptors;
bool _usesInterceptor = false;
- Setlet<ClassElement> _typeConstants;
Setlet<FunctionElement> _asyncMarkers;
_CodegenImpact();
@@ -108,17 +105,6 @@ class _CodegenImpact extends WorldImpactBuilderImpl implements CodegenImpact {
bool get usesInterceptor => _usesInterceptor;
- void registerTypeConstant(ClassElement element) {
- if (_typeConstants == null) {
- _typeConstants = new Setlet<ClassElement>();
- }
- _typeConstants.add(element);
- }
-
- Iterable<ClassElement> get typeConstants {
- return _typeConstants != null ? _typeConstants : const <ClassElement>[];
- }
-
void registerAsyncMarker(FunctionElement element) {
if (_asyncMarkers == null) {
_asyncMarkers = new Setlet<FunctionElement>();
@@ -187,10 +173,6 @@ class CodegenRegistry {
worldImpact.registerUseInterceptor();
}
- void registerTypeConstant(ClassElement element) {
- worldImpact.registerTypeConstant(element);
- }
-
void registerInstantiation(ResolutionInterfaceType type) {
registerTypeUse(new TypeUse.instantiation(type));
}
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_backend/backend.dart » ('j') | pkg/compiler/lib/src/ssa/codegen.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698