Register type constants through ConstantUse

pkg/compiler/lib/src/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:math' as math;
 import '../common.dart';
 import '../common/codegen.dart' show CodegenRegistry, CodegenWorkItem;
 import '../common/tasks.dart' show CompilerTask;
 import '../compiler.dart' show Compiler;
 import '../constants/constant_system.dart';
@@ skipping 2054 matching lines @@
       // Use !0 for true, !1 for false.
       return new js.Prefix("!", new js.LiteralNumber(value ? "0" : "1"))
           .withSourceInformation(sourceInformation);
     } else {
       return new js.LiteralBool(value).withSourceInformation(sourceInformation);
     }
   }
 
   void generateConstant(
       ConstantValue constant, SourceInformation sourceInformation) {
-    if (constant.isFunction) {
-      FunctionConstantValue function = constant;
-      registry.registerStaticUse(new StaticUse.staticTearOff(function.element));

[Siggi Cherem (dart-lang), 2017/03/14 05:48:40]

I saw the changes below in the listener, but is this one already handled there?
were we registering this twice?

[Johnni Winther, 2017/03/15 13:47:05]

Yes.

-    }
-    if (constant.isType) {
-      // If the type is a web component, we need to ensure the constructors are
-      // available to 'upgrade' the native object.
-      TypeConstantValue type = constant;
-      if (type.representedType.isInterfaceType) {
-        InterfaceType representedType = type.representedType;
-        registry.registerTypeConstant(representedType.element);
-      }
-    }
     js.Expression expression = backend.emitter.constantReference(constant);
     if (!constant.isDummy) {
       // TODO(johnniwinther): Support source information on synthetic constants.
       expression = expression.withSourceInformation(sourceInformation);
     }
     push(expression);
   }
 
   visitConstant(HConstant node) {
     assert(isGenerateAtUseSite(node));
@@ skipping 1030 matching lines @@
     registry.registerStaticUse(new StaticUse.staticInvoke(
         helper, new CallStructure.unnamed(argumentCount)));
     return backend.emitter.staticFunctionAccess(helper);
   }
 
   @override
   void visitRef(HRef node) {
     visit(node.value);
   }
 }