Refine the accessibility label of Clear Browsing Data flow.

Refine the accessibility label of Clear Browsing Data flow.

When using VoiceOver, the user taps a button to Clear Browsing Data then
gets on a new Clear Browsing Data button, which can be confusing.
To make it more understandable, this CL changes the accessibility label
of the second button to "Confirm Clear Browsing Data".

BUG=688415
R=lindsayw@chromium.org

Review-Url: https://codereview.chromium.org/2750403002
Cr-Commit-Position: refs/heads/master@{#458186}
Committed: https://chromium.googlesource.com/chromium/src/+/cf84fa5c1519b0d0867d49071d3266004605d53b

[lpromero, 2017-03-16 16:57:10]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 16:57:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 17:09:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 17:09:23]

Dry run: This issue passed the CQ dry run.

[lindsayw, 2017-03-16 18:49:52]

LGTM with nit

https://codereview.chromium.org/2750403002/diff/1/ios/chrome/app/strings/ios_...
File ios/chrome/app/strings/ios_strings.grd (right):

https://codereview.chromium.org/2750403002/diff/1/ios/chrome/app/strings/ios_...
ios/chrome/app/strings/ios_strings.grd:510: <message
name="IDS_IOS_CONFIRM_CLEAR_BUTTON" desc="Accessibility label for the action
sheet button used to clear data. [iOS only]">
nit:

Can we please include specifically "confirm" in the desc here? Along the lines
of "...for the action sheet button used to confirm clearing data." or something
akin to that?

[lpromero, 2017-03-17 13:34:05]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[lpromero, 2017-03-17 13:34:11]

https://codereview.chromium.org/2750403002/diff/1/ios/chrome/app/strings/ios_...
File ios/chrome/app/strings/ios_strings.grd (right):

https://codereview.chromium.org/2750403002/diff/1/ios/chrome/app/strings/ios_...
ios/chrome/app/strings/ios_strings.grd:510: <message
name="IDS_IOS_CONFIRM_CLEAR_BUTTON" desc="Accessibility label for the action
sheet button used to clear data. [iOS only]">
On 2017/03/16 18:49:52, lindsayw wrote:
> nit:
> 
> Can we please include specifically "confirm" in the desc here? Along the lines
> of "...for the action sheet button used to confirm clearing data." or
something
> akin to that?

Good call. Done.

[commit-bot: I haz the power, 2017-03-17 13:34:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpromero, 2017-03-17 13:34:16]

The CQ bit was checked by lpromero@chromium.org

[lpromero, 2017-03-17 13:34:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
lindsayw@chromium.org
Link to the patchset: https://codereview.chromium.org/2750403002/#ps20001
(title: "Refine string description")

[commit-bot: I haz the power, 2017-03-17 13:34:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 13:34:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 13:34:27]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[lpromero, 2017-03-17 13:34:39]

The CQ bit was checked by lpromero@chromium.org

[commit-bot: I haz the power, 2017-03-17 13:34:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 13:34:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 13:35:00]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[lpromero, 2017-03-17 13:35:01]

lpromero@chromium.org changed reviewers:
+ noyau@chromium.org

[lpromero, 2017-03-17 13:35:01]

+noyau: as committer, can you approve and CQ?

[Olivier, 2017-03-20 18:12:21]

olivierrobin@chromium.org changed reviewers:
+ olivierrobin@chromium.org

[Olivier, 2017-03-20 18:12:21]

lgtm

[lpromero, 2017-03-20 20:49:43]

The CQ bit was checked by lpromero@chromium.org

[commit-bot: I haz the power, 2017-03-20 20:50:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 21:15:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490042983008100,
"parent_rev": "e43c093fdaa7ce7eb41a084a15ff5fa12f08537d", "commit_rev":
"cf84fa5c1519b0d0867d49071d3266004605d53b"}

[commit-bot: I haz the power, 2017-03-20 21:16:42]

Description was changed from

==========
Refine the accessibility label of Clear Browsing Data flow.

When using VoiceOver, the user taps a button to Clear Browsing Data then
gets on a new Clear Browsing Data button, which can be confusing.
To make it more understandable, this CL changes the accessibility label
of the second button to "Confirm Clear Browsing Data".

BUG=688415
R=lindsayw@chromium.org
==========

to

==========
Refine the accessibility label of Clear Browsing Data flow.

When using VoiceOver, the user taps a button to Clear Browsing Data then
gets on a new Clear Browsing Data button, which can be confusing.
To make it more understandable, this CL changes the accessibility label
of the second button to "Confirm Clear Browsing Data".

BUG=688415
R=lindsayw@chromium.org

Review-Url: https://codereview.chromium.org/2750403002
Cr-Commit-Position: refs/heads/master@{#458186}
Committed:
https://chromium.googlesource.com/chromium/src/+/cf84fa5c1519b0d0867d49071d32...
==========

[commit-bot: I haz the power, 2017-03-20 21:16:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cf84fa5c1519b0d0867d49071d32...

[gchatz, 2017-03-20 23:24:06]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2763793002/ by gchatz@chromium.org.

The reason for reverting is: Caused a variety of EG test failures.
For example:
SettingsTestCase.testClearPasswords
SettingsTestCase.testClearPasswords:
../../ios/chrome/browser/ui/settings/settings_egtest.mm:294: error:
-[SettingsTestCase testClearPasswords] : Exception: NoMatchingElementException

Exception Name: NoMatchingElementException
Exception Reason: Cannot find UI element.
Exception with Action: {
  "Action Name" : "Tap",
  "Element Matcher" : "((((respondsToSelector(isAccessibilityElement) &&
isAccessibilityElement) && accessibilityLabel('Clear Browsing Data')) &&
((respondsToSelector(isAccessibilityElement) && isAccessibilityElement) &&
accessibilityTraits: UIAccessibilityTraitButton)) &&
!kindOfClass('MDCCollectionViewTextCell'))",
  "Recovery Suggestion" : "Check if element exists in the UI, modify assert
criteria, or adjust the matcher"
}.

[lpromero, 2017-03-21 10:56:04]

On 2017/03/20 23:24:06, gchatz wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/2763793002/ by mailto:gchatz@chromium.org.
> 
> The reason for reverting is: Caused a variety of EG test failures.
> For example:
> SettingsTestCase.testClearPasswords
> SettingsTestCase.testClearPasswords:
> ../../ios/chrome/browser/ui/settings/settings_egtest.mm:294: error:
> -[SettingsTestCase testClearPasswords] : Exception: NoMatchingElementException
> 
> Exception Name: NoMatchingElementException
> Exception Reason: Cannot find UI element.
> Exception with Action: {
>   "Action Name" : "Tap",
>   "Element Matcher" : "((((respondsToSelector(isAccessibilityElement) &&
> isAccessibilityElement) && accessibilityLabel('Clear Browsing Data')) &&
> ((respondsToSelector(isAccessibilityElement) && isAccessibilityElement) &&
> accessibilityTraits: UIAccessibilityTraitButton)) &&
> !kindOfClass('MDCCollectionViewTextCell'))",
>   "Recovery Suggestion" : "Check if element exists in the UI, modify assert
> criteria, or adjust the matcher"
> }.

Reland at https://codereview.chromium.org/2763943002