Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 2763793002: Revert of Refine the accessibility label of Clear Browsing Data flow. (Closed)

Created:
8 months, 1 week ago by gchatz
Modified:
8 months, 1 week ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, srahim+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Refine the accessibility label of Clear Browsing Data flow. (patchset #2 id:20001 of https://codereview.chromium.org/2750403002/ ) Reason for revert: Caused a variety of EG test failures. For example: SettingsTestCase.testClearPasswords SettingsTestCase.testClearPasswords: ../../ios/chrome/browser/ui/settings/settings_egtest.mm:294: error: -[SettingsTestCase testClearPasswords] : Exception: NoMatchingElementException Exception Name: NoMatchingElementException Exception Reason: Cannot find UI element. Exception with Action: { "Action Name" : "Tap", "Element Matcher" : "((((respondsToSelector(isAccessibilityElement) && isAccessibilityElement) && accessibilityLabel('Clear Browsing Data')) && ((respondsToSelector(isAccessibilityElement) && isAccessibilityElement) && accessibilityTraits: UIAccessibilityTraitButton)) && !kindOfClass('MDCCollectionViewTextCell'))", "Recovery Suggestion" : "Check if element exists in the UI, modify assert criteria, or adjust the matcher" } Original issue's description: > Refine the accessibility label of Clear Browsing Data flow. > > When using VoiceOver, the user taps a button to Clear Browsing Data then > gets on a new Clear Browsing Data button, which can be confusing. > To make it more understandable, this CL changes the accessibility label > of the second button to "Confirm Clear Browsing Data". > > BUG=688415 > R=lindsayw@chromium.org > > Review-Url: https://codereview.chromium.org/2750403002 > Cr-Commit-Position: refs/heads/master@{#458186} > Committed: https://chromium.googlesource.com/chromium/src/+/cf84fa5c1519b0d0867d49071d3266004605d53b TBR=lindsayw@chromium.org,noyau@chromium.org,olivierrobin@chromium.org,lpromero@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=688415 Review-Url: https://codereview.chromium.org/2763793002 Cr-Commit-Position: refs/heads/master@{#458234} Committed: https://chromium.googlesource.com/chromium/src/+/b1cb679f18cefc5699f848827ba9b94751ec898c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M ios/chrome/app/strings/ios_strings.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm View 1 chunk +0 lines, -2 lines 0 comments Download
Trybot results:

Messages

Total messages: 12 (6 generated)
gchatz
Created Revert of Refine the accessibility label of Clear Browsing Data flow.
8 months, 1 week ago (2017-03-20 23:24:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763793002/1
8 months, 1 week ago (2017-03-20 23:24:49 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
8 months, 1 week ago (2017-03-20 23:24:51 UTC) #5
edchin
lgtm
8 months, 1 week ago (2017-03-20 23:25:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763793002/1
8 months, 1 week ago (2017-03-20 23:27:02 UTC) #9
commit-bot: I haz the power
8 months, 1 week ago (2017-03-20 23:29:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b1cb679f18cefc5699f848827ba9...

Powered by Google App Engine
This is Rietveld efc10ee0f