Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 2763943002: Refine the accessibility label of Clear Browsing Data flow. (Closed)

Created:
3 years, 9 months ago by lpromero
Modified:
3 years, 9 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, srahim+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refine the accessibility label of Clear Browsing Data flow. When using VoiceOver, the user taps a button to Clear Browsing Data then gets on a new Clear Browsing Data button, which can be confusing. To make it more understandable, this CL changes the accessibility label of the second button to "Confirm Clear Browsing Data". This is a reland of https://codereview.chromium.org/2750403002 BUG=688415 R=lindsayw@chromium.org Review-Url: https://codereview.chromium.org/2763943002 Cr-Commit-Position: refs/heads/master@{#458415} Committed: https://chromium.googlesource.com/chromium/src/+/145e3d92be1f7d6a82ccaa93e5653efb5115d0f1

Patch Set 1 #

Patch Set 2 : Fix EG tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M ios/chrome/app/strings/ios_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/settings/settings_egtest.mm View 1 3 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
lpromero
+noyau: this is a reland. Original CL is patchset 1 and the diff is patchset ...
3 years, 9 months ago (2017-03-21 10:39:02 UTC) #7
lpromero
3 years, 9 months ago (2017-03-21 10:39:13 UTC) #9
noyau (Ping after 24h)
lgtm
3 years, 9 months ago (2017-03-21 14:17:11 UTC) #12
lindsayw
lgtm lgtm, sorry I didn't mention the clearbrowsingdata issue in the settings tests earlier :)
3 years, 9 months ago (2017-03-21 14:19:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763943002/20001
3 years, 9 months ago (2017-03-21 15:07:39 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/145e3d92be1f7d6a82ccaa93e5653efb5115d0f1
3 years, 9 months ago (2017-03-21 15:14:26 UTC) #18
mrefaat
3 years, 9 months ago (2017-03-21 18:15:15 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2760313003/ by mrefaat@chromium.org.

The reason for reverting is: Broke History UITestCase.testClearBrowsingHistory
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FEarlGreyi...
.

Powered by Google App Engine
This is Rietveld 408576698