Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2749943002: Remove obsolete v8_shell flags from gypv8sh.py (Closed)

Created:
3 years, 9 months ago by dpapad
Modified:
3 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete v8_shell flags from gypv8sh.py These flags do not exist and cause the following warning Warning: unknown flag --icu-data-file=./icudtl.dat. Warning: unknown flag --natives_blob=./natives_blob.bin. Warning: unknown flag --snapshot_blob=./snapshot_blob.bin. They are probably a left-over from when gypv8sh.py was using d8, and should have been removed at https://codereview.chromium.org/1953233002. BUG=None Review-Url: https://codereview.chromium.org/2749943002 Cr-Commit-Position: refs/heads/master@{#456905} Committed: https://chromium.googlesource.com/chromium/src/+/3fae4d36245600ce148e4c827271c34b38a85b9b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M tools/gypv8sh.py View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
dpapad
I was investigating the whole gypv8sh.py, js2gtest.js and js2gtest.gni mechanism, for other purposes (future simplification, ...
3 years, 9 months ago (2017-03-14 22:37:20 UTC) #8
Dirk Pranke
lgtm
3 years, 9 months ago (2017-03-14 23:49:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749943002/1
3 years, 9 months ago (2017-03-15 00:01:46 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 00:11:44 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3fae4d36245600ce148e4c827271...

Powered by Google App Engine
This is Rietveld 408576698