Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1953233002: Use the v8 shell instead of d8 to compile jstests (Closed)

Created:
4 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 7 months ago
CC:
aboxhall+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, oshima+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the v8 shell instead of d8 to compile jstests BUG=609107 R=machenbach@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/11513aa0e64b7be852f123c7f3dedc9be50b78ff Cr-Commit-Position: refs/heads/master@{#392891}

Patch Set 1 #

Patch Set 2 : rename to v8_shell #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M build/all.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/js_unittest_rules.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/js2gtest.gni View 1 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
jochen (gone - plz use gerrit)
ptal depends on https://crrev.com/609b5e5e30b719805dfe31f2f44f61d1293e83e8 Locally, it works :)
4 years, 7 months ago (2016-05-06 07:45:38 UTC) #3
Michael Achenbach
lgtm. What has been done looks right. Can't judge the completeness. Not all the gyp ...
4 years, 7 months ago (2016-05-06 08:15:14 UTC) #4
jochen (gone - plz use gerrit)
On 2016/05/06 at 08:15:14, machenbach wrote: > lgtm. What has been done looks right. Can't ...
4 years, 7 months ago (2016-05-06 09:31:58 UTC) #5
Michael Achenbach
On 2016/05/06 09:31:58, jochen wrote: > On 2016/05/06 at 08:15:14, machenbach wrote: > > lgtm. ...
4 years, 7 months ago (2016-05-06 10:22:30 UTC) #6
Dirk Pranke
lgtm.
4 years, 7 months ago (2016-05-06 22:37:23 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953233002/1
4 years, 7 months ago (2016-05-09 06:50:57 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/107788)
4 years, 7 months ago (2016-05-09 07:06:04 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953233002/20001
4 years, 7 months ago (2016-05-11 08:46:01 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-11 09:50:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953233002/20001
4 years, 7 months ago (2016-05-11 09:56:27 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-11 10:00:05 UTC) #19
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 10:01:28 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/11513aa0e64b7be852f123c7f3dedc9be50b78ff
Cr-Commit-Position: refs/heads/master@{#392891}

Powered by Google App Engine
This is Rietveld 408576698