Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: tools/gypv8sh.py

Issue 2749943002: Remove obsolete v8_shell flags from gypv8sh.py (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gypv8sh.py
diff --git a/tools/gypv8sh.py b/tools/gypv8sh.py
index d1f246c8b4fc37f434e6914c4456153a3bf237f7..e6d655f7f83bed61b7f4e98b47a1afe3dd42ac86 100755
--- a/tools/gypv8sh.py
+++ b/tools/gypv8sh.py
@@ -45,15 +45,6 @@ def main ():
(v8_shell, mock_js, test_api, js2webui, test_type,
inputfile, inputrelfile, cxxoutfile, jsoutfile) = args
cmd = [v8_shell]
- icudatafile = os.path.join(os.path.dirname(v8_shell), 'icudtl.dat')
- if os.path.exists(icudatafile):
- cmd.extend(['--icu-data-file=%s' % icudatafile])
- v8nativesfile = os.path.join(os.path.dirname(v8_shell), 'natives_blob.bin')
- if opts.external == 'y' and os.path.exists(v8nativesfile):
- cmd.extend(['--natives_blob=%s' % v8nativesfile])
- v8snapshotfile = os.path.join(os.path.dirname(v8_shell), 'snapshot_blob.bin')
- if opts.external == 'y' and os.path.exists(v8snapshotfile):
- cmd.extend(['--snapshot_blob=%s' % v8snapshotfile])
arguments = [js2webui, inputfile, inputrelfile, opts.deps_js,
cxxoutfile, test_type]
cmd.extend(['-e', "arguments=" + json.dumps(arguments), mock_js,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698