Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 274943003: Create new histrograms for ExtensionPermission enum. (Closed)

Created:
6 years, 7 months ago by rpaquay
Modified:
6 years, 6 months ago
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, extensions-reviews_chromium.org, jar (doing other things), asvitkine+watch_chromium.org, estade+watch_chromium.org, chromium-apps-reviews_chromium.org, pedrosimonetti+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Create new histograms (with "2" suffix) corresponding to histograms using the "ExtensionPermission" enum. Also, update the histograms owners and mark the old histograms as obsolete. BUG=338008 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274728

Patch Set 1 #

Patch Set 2 : Rebasing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -39 lines) Patch
M chrome/browser/extensions/api/webstore_private/webstore_private_api.cc View 1 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_disabled_ui.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/installed_loader.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/navigation_observer.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 10 chunks +173 lines, -12 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
rpaquay
mek@chromium.org: Please review changes in chrome/browser/extensions/* mpearson@chromium.org: Please review changes in tools/metrics/histograms/histograms.xml xiyuan@chromium.org: Please review ...
6 years, 7 months ago (2014-05-14 20:19:56 UTC) #1
xiyuan
webui/ntp/app_launcher_handler.cc LGTM
6 years, 7 months ago (2014-05-14 20:24:19 UTC) #2
Mark P
histograms.xml lgtm
6 years, 7 months ago (2014-05-14 22:25:51 UTC) #3
Marijn Kruisselbrink
lgtm
6 years, 7 months ago (2014-05-14 22:56:12 UTC) #4
rpaquay
The CQ bit was checked by rpaquay@chromium.org
6 years, 7 months ago (2014-05-14 23:07:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rpaquay@chromium.org/274943003/1
6 years, 7 months ago (2014-05-14 23:09:39 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 00:01:33 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-15 00:06:21 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/67767) ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/152087) linux_chromium_chromeos_rel ...
6 years, 7 months ago (2014-05-15 00:06:22 UTC) #9
rpaquay
The CQ bit was checked by rpaquay@chromium.org
6 years, 7 months ago (2014-05-15 19:44:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rpaquay@chromium.org/274943003/1
6 years, 7 months ago (2014-05-15 19:44:38 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 20:16:20 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-15 20:20:46 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/4692) linux_chromium_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_dbg/builds/25522) linux_chromium_rel ...
6 years, 7 months ago (2014-05-15 20:20:46 UTC) #14
rpaquay
The CQ bit was checked by rpaquay@chromium.org
6 years, 6 months ago (2014-06-03 16:32:56 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rpaquay@chromium.org/274943003/20001
6 years, 6 months ago (2014-06-03 16:33:46 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-03 19:52:11 UTC) #17
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 08:39:17 UTC) #18
Message was sent while issue was closed.
Change committed as 274728

Powered by Google App Engine
This is Rietveld 408576698