Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 274943003: Create new histrograms for ExtensionPermission enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_disabled_ui.cc ('k') | chrome/browser/extensions/installed_loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 5781851189c7359179f2a5e416b7768e8c1e0739..41acccfb56c45cee278b9570a1535afa41248856 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -742,7 +742,7 @@ bool ExtensionService::UninstallExtension(
UMA_HISTOGRAM_ENUMERATION("Extensions.UninstallType",
extension->GetType(), 100);
RecordPermissionMessagesHistogram(extension.get(),
- "Extensions.Permissions_Uninstall");
+ "Extensions.Permissions_Uninstall2");
// Unload before doing more cleanup to ensure that nothing is hanging on to
// any of these resources.
@@ -956,8 +956,8 @@ void ExtensionService::DisableUserExtensions(
void ExtensionService::GrantPermissionsAndEnableExtension(
const Extension* extension) {
GrantPermissions(extension);
- RecordPermissionMessagesHistogram(
- extension, "Extensions.Permissions_ReEnable");
+ RecordPermissionMessagesHistogram(extension,
+ "Extensions.Permissions_ReEnable2");
extension_prefs_->SetDidExtensionEscalatePermissions(extension, false);
EnableExtension(extension->id());
}
@@ -1709,8 +1709,8 @@ void ExtensionService::CheckPermissionsIncrease(const Extension* extension,
} else if (is_privilege_increase) {
disable_reasons |= Extension::DISABLE_PERMISSIONS_INCREASE;
if (!extension_prefs_->DidExtensionEscalatePermissions(extension->id())) {
- RecordPermissionMessagesHistogram(
- extension, "Extensions.Permissions_AutoDisable");
+ RecordPermissionMessagesHistogram(extension,
+ "Extensions.Permissions_AutoDisable2");
}
extension_prefs_->SetExtensionState(extension->id(), Extension::DISABLED);
extension_prefs_->SetDidExtensionEscalatePermissions(extension, true);
@@ -1815,8 +1815,8 @@ void ExtensionService::OnExtensionInstalled(
extension->GetType(), 100);
UMA_HISTOGRAM_ENUMERATION("Extensions.InstallSource",
extension->location(), Manifest::NUM_LOCATIONS);
- RecordPermissionMessagesHistogram(
- extension, "Extensions.Permissions_Install");
+ RecordPermissionMessagesHistogram(extension,
+ "Extensions.Permissions_Install2");
} else {
UMA_HISTOGRAM_ENUMERATION("Extensions.UpdateType",
extension->GetType(), 100);
« no previous file with comments | « chrome/browser/extensions/extension_disabled_ui.cc ('k') | chrome/browser/extensions/installed_loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698