chrome/browser/extensions/crx_installer.cc - Issue 274943003: Create new histrograms for ExtensionPermission enum.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/crx_installer.cc

Issue 274943003: Create new histrograms for ExtensionPermission enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebasing. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/webstore_private/webstore_private_api.cc ('k') | chrome/browser/extensions/extension_disabled_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/crx_installer.cc

diff --git a/chrome/browser/extensions/crx_installer.cc b/chrome/browser/extensions/crx_installer.cc

index b77769ff455590584b3e6232c284f5dacda26f6b..32e27aa3b650d8719c099d442b2b3640aabf90a1 100644

--- a/chrome/browser/extensions/crx_installer.cc

+++ b/chrome/browser/extensions/crx_installer.cc

@@ -659,9 +659,9 @@ void CrxInstaller::InstallUIAbort(bool user_initiated) {

// and if it is false, this function is called in response to

// ExtensionInstallPrompt::ConfirmInstall().

if (!update_from_settings_page_) {

- std::string histogram_name = user_initiated ?

- "Extensions.Permissions_InstallCancel" :

- "Extensions.Permissions_InstallAbort";

+ std::string histogram_name = user_initiated

+ ? "Extensions.Permissions_InstallCancel2"

+ : "Extensions.Permissions_InstallAbort2";

ExtensionService::RecordPermissionMessagesHistogram(

extension(), histogram_name.c_str());